faster PCUICSR #1081
Merged
faster PCUICSR #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm amazed that it's only two occurrences that take up that long! |
|
FTR I have had firstorder on my radar for a while. It's very inefficient because it strongly normalizes all terms from the context. (It's a bit sad that these instances will disappear for benching purposes, btw.) |
|
Would that be reason enough to keep them though? Could we keep them as a special CI that only runs for benchmarks? |
|
It does not seem reasonable to me to not fix it so that the firstorder issue stays in the CI. @ppedrot It should be easy to make a specific test-case for that no? |
|
Thanks @mrhaandi ! |
|
Note that coq/coq#19126 has probably made this PR much less usefull in practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced slow
firstordercalls by appropriateconstructor,left,rightcalls.This improves performance from
5m49.68s | 2644580 ko | PCUICSR.voto
0m49.37s | 1443968 ko | PCUICSR.vo,also improving overall project compilation speed.