Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add some docs #7

Merged
merged 6 commits into from
Sep 28, 2024
Merged

docs: add some docs #7

merged 6 commits into from
Sep 28, 2024

Conversation

CoolLoong
Copy link
Contributor

doc: link
doc: AckOrNack::extend_from
doc: Route
doc: Role
doc: OfflineState
doc: OfflineHandler
doc: Framed

doc: link
doc: AckOrNack::extend_from
doc: Route
doc: Role
doc: OfflineState
doc: OfflineHandler
doc: Framed
Copy link
Member

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, here are some suggested modifications.

src/codec/frame.rs Outdated Show resolved Hide resolved
src/codec/frame.rs Outdated Show resolved Hide resolved
src/link.rs Outdated Show resolved Hide resolved
src/link.rs Outdated Show resolved Hide resolved
src/server/handler/offline.rs Outdated Show resolved Hide resolved
@iGxnon
Copy link
Member

iGxnon commented Sep 25, 2024

https://github.com/bnjbvr/cargo-machete seems to have just released a new version, there are some issues with cargo-binstall in the CI, but that's okay.

Copy link
Member

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@iGxnon iGxnon merged commit 8378353 into MemoriesOfTime:main Sep 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants