Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/cmake.yml:add tests for recent gcc versions;migrate to checkoutv3 #250

Merged
merged 17 commits into from
Aug 20, 2022

Conversation

andy5995
Copy link
Collaborator

@andy5995 andy5995 commented Aug 17, 2022

fixes #247

@andy5995 andy5995 force-pushed the ci-gcc-recent branch 2 times, most recently from 10965f4 to 5fff0e0 Compare August 17, 2022 04:34
@andy5995 andy5995 marked this pull request as draft August 17, 2022 04:40
@andy5995 andy5995 force-pushed the ci-gcc-recent branch 2 times, most recently from fa79081 to 4e554b4 Compare August 17, 2022 05:13
gcc and clang build is failing on Jammy with the message:

'cannot find -lssh: No such file or directory'

Basically I added libcurl-openssl-dev to the deps
Trying to correct:

 The following packages have unmet dependencies:
libcurl4-gnutls-dev : Conflicts: libcurl4-openssl-dev but
7.81.0-1ubuntu1.3 is to be installed
libcurl4-openssl-dev : Conflicts: libcurl4-gnutls-dev but
7.81.0-1ubuntu1.3 is to be installed
E: Unable to correct problems, you have held broken packages.
An error occurred while installing build dependencies.
@andy5995
Copy link
Collaborator Author

When I added include(FindCurl) I started getting these errors:

-- Found CPPUNIT: /usr/lib/libcppunit.so  
-- ** Searching for library: FriBiDi...
-- Using FriBiDi: /usr/lib/libfribidi.so
-- Checking for one of the modules 'streflop-sse'
-- Checking for one of the modules 'streflop'
-- Search for Library STREFLOP result =  libs:  include dirs: 
-- EXTERNAL_LIBS = [/usr/lib/libcppunit.so;/usr/lib/libSDL2main.a;/usr/lib/libSDL2.so;/usr/lib/libfribidi.so;glib-2.0]
-- ***Note: The final output path for the MegaGlest engine will be [/home/andy/src/megaglest-source/mk/linux/]
-- **Found game data.
-- =====> Found Define: STREFLOP_SSE
-- =====> Found Define: HAS_GCC_BACKTRACE
-- Configuring incomplete, errors occurred!
See also "/home/andy/src/megaglest-source/mk/linux/build/CMakeFiles/CMakeOutput.log".
See also "/home/andy/src/megaglest-source/mk/linux/build/CMakeFiles/CMakeError.log".
ERROR: CMAKE failed.

When I searched the 2 log files mentioned, there were no instances of 'curl' or 'module'.

I fixed it by using the correct CASE mentioned in the FindCURL cmake docs.

Anyway, including the module didn't fix #251 unfortunately.

@andy5995 andy5995 force-pushed the ci-gcc-recent branch 4 times, most recently from 2c4acc6 to cbf7291 Compare August 17, 2022 16:47
@andy5995 andy5995 changed the title workflows/cmake.yml:test on Ubuntu Jammy (22.04);migrate to checkoutv3 workflows/cmake.yml:add test for gcc 10 and 11;migrate to checkoutv3 Aug 17, 2022
@andy5995 andy5995 marked this pull request as ready for review August 17, 2022 17:13
@andy5995 andy5995 marked this pull request as draft August 17, 2022 18:41
.github/workflows/cmake.yml Outdated Show resolved Hide resolved
.github/workflows/cmake.yml Outdated Show resolved Hide resolved
@andy5995 andy5995 marked this pull request as ready for review August 17, 2022 19:52
@andy5995 andy5995 marked this pull request as draft August 17, 2022 20:01
@andy5995 andy5995 marked this pull request as ready for review August 18, 2022 15:21
@andy5995 andy5995 marked this pull request as draft August 18, 2022 15:58
@andy5995 andy5995 changed the title workflows/cmake.yml:add test for gcc 10 and 11;migrate to checkoutv3 workflows/cmake.yml:add tests for recent gcc versions;migrate to checkoutv3 Aug 18, 2022
@andy5995 andy5995 marked this pull request as ready for review August 18, 2022 16:51
@andy5995 andy5995 force-pushed the ci-gcc-recent branch 5 times, most recently from debc887 to 9896cbf Compare August 20, 2022 21:50
on:
push:
branches: [ develop ]
pull_request:
Copy link
Collaborator Author

@andy5995 andy5995 Aug 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L8 and 9 can be removed before the PR gets merged.

@Jammyjamjamman Jammyjamjamman merged commit 77d6961 into MegaGlest:develop Aug 20, 2022
@Jammyjamjamman Jammyjamjamman deleted the ci-gcc-recent branch August 20, 2022 22:31
Rampoina pushed a commit to Rampoina/megaglest-source that referenced this pull request Aug 25, 2022
…koutv3 (MegaGlest#250)

* workflows/cmake.yml:test on Ubuntu Jammy (22.04);migrate to checkoutv3

This should also fix MegaGlest#247

* maybe fix ssh link error on Ubuntu Jammy

gcc and clang build is failing on Jammy with the message:

'cannot find -lssh: No such file or directory'

Basically I added libcurl-openssl-dev to the deps

* remove libcurl4-gnutls-dev

Trying to correct:

 The following packages have unmet dependencies:
libcurl4-gnutls-dev : Conflicts: libcurl4-openssl-dev but
7.81.0-1ubuntu1.3 is to be installed
libcurl4-openssl-dev : Conflicts: libcurl4-gnutls-dev but
7.81.0-1ubuntu1.3 is to be installed
E: Unable to correct problems, you have held broken packages.
An error occurred while installing build dependencies.

* use cmake FindCURL module

* for OpenSSL, use include instead of find_package

* remove jammy, add gcc-10 and 11 test

* revert now-unrelated changes

* clean-up

* add VERBOSE flag to make

* Update .github/workflows/cmake.yml

* Update .github/workflows/cmake.yml

* use '-f' option from build script to force clang

* force dynamic libs with '-d'

fixes MegaGlest#251

* mk/linux/setupBuildDeps.sh:fix script so 22.04 is detected

*remove vlc deps (not required for the CI)
*remove ubuntu-18.04 from the build matrix, see
https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/

* revert removal of commented macos jobs

* run apt-get update and upgrade

* cleanup Prep snapshot section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI needs additional tests for more recent compilers
2 participants