feat: Exclude bcprov-jdk15on from wallet packaging - EXO-59676 - Meeds-io/MIPs#69 #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-io/MIPs#69 Prior to this change, bcprov-jdk15on jar is added in wallet packaging as it's coming as a compiled dependency in org.web3j.utils. This PR exclude this jar from compiled scope to not have an issue on unexisting dependancy when unistalling the wallet addon
hakermi
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
rdenarie
approved these changes
Jul 24, 2023
hakermi
added a commit
that referenced
this pull request
Jul 26, 2023
…s-io/MIPs#69 (#393) Prior to this change, bcprov-jdk15on jar is added in wallet packaging as it's coming as a compiled dependency in org.web3j.utils. With new feature about the new Argon2IdPasswordEncoder, this dependency is needed at gatein portal level. So this PR exclude this jar from compiled scope, so that, if someone uninstall wallet addon, the bcprov-jdk15on is not removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, bcprov-jdk15on jar is added in wallet packaging as it's coming as a compiled dependency in org.web3j.utils.
With new feature about the new Argon2IdPasswordEncoder, this dependency is needed at gatein portal level. So this PR exclude this jar from compiled scope, so that, if someone uninstall wallet addon, the bcprov-jdk15on is not removed.