Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Wallet Initialization Gamification Trigger - MEED-2208 - Meeds-io/MIPs#50 #390

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

boubaker
Copy link
Member

  • This change will introduce a new Trigger to gamification for wallet first creation.
  • Allow to send initial funds to First initialization of Metamask Wallet Prior to this change, when initializing Metamask wallet for the first time for a user, the initial funds wasn't sent to user. This change will allow to send initial funds for a given user for the first time only by triggering the generic event 'exo.wallet.addressAssociation.new' which was triggered only when the wallet is initialized with a Browser Wallet.

…eds-io/MIPs#50 (#381)

* This change will introduce a new Trigger to gamification for wallet
first creation.
* Allow to send initial funds to First initialization of Metamask Wallet
Prior to this change, when initializing Metamask wallet for the first
time for a user, the initial funds wasn't sent to user. This change will
allow to send initial funds for a given user for the first time only by
triggering the generic event 'exo.wallet.addressAssociation.new' which
was triggered only when the wallet is initialized with a Browser Wallet.
@boubaker boubaker requested a review from rdenarie July 19, 2023 05:08
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

57.1% 57.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@boubaker boubaker linked an issue Jul 19, 2023 that may be closed by this pull request
@boubaker boubaker merged commit 36a2d56 into develop Jul 20, 2023
2 of 3 checks passed
@boubaker boubaker deleted the merge-meed-mips-50 branch July 20, 2023 07:44
exo-swf pushed a commit that referenced this pull request Jul 20, 2023
…eds-io/MIPs#50 (#390)

* This change will introduce a new Trigger to gamification for wallet
first creation.
* Allow to send initial funds to First initialization of Metamask Wallet
Prior to this change, when initializing Metamask wallet for the first
time for a user, the initial funds wasn't sent to user. This change will
allow to send initial funds for a given user for the first time only by
triggering the generic event 'exo.wallet.addressAssociation.new' which
was triggered only when the wallet is initialized with a Browser Wallet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributions UX & Navigation
2 participants