Skip to content

Commit

Permalink
feat: Exclude bcprov-jdk15on from wallet packaging - EXO-59676 - Meed…
Browse files Browse the repository at this point in the history
…s-io/MIPs#69  (#395)

Prior to this change, bcprov-jdk15on jar is added in wallet packaging as
it's coming as a compiled dependency in org.web3j.utils.

With new feature about the new Argon2IdPasswordEncoder, this dependency
is needed at gatein portal level. So this PR exclude this jar from
compiled scope, so that, if someone uninstall wallet addon, the
bcprov-jdk15on is not removed.
  • Loading branch information
hakermi authored and rdenarie committed Aug 11, 2023
1 parent f431cd3 commit 49e8471
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions wallet-packaging/src/main/assemblies/assembly.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
<includes>
<include>*:*:jar</include>
</includes>
<excludes>
<exclude>org.bouncycastle:bcprov-jdk15on:jar</exclude>
</excludes>
<scope>compile</scope>
<outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
</dependencySet>
Expand Down

0 comments on commit 49e8471

Please sign in to comment.