Right to left display of ko in admin interface and some labels are in English instead of Arabic - EXO-73560 - Meeds-io/meeds#2308. #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrout
reviewed
Aug 12, 2024
| @@ -29,6 +29,9 @@ export default { | |||
| fullDisplayAllowed() { | |||
| return this.$vuetify.breakpoint.width >= this.$vuetify.breakpoint.thresholds.lg; | |||
| }, | |||
| isLanguageArabic() { | |||
There was a problem hiding this comment.
IMO, it will better to use eXo.env.portal.orientation to check the text orientation, then testing the laguage
akhanfir
force-pushed
the
TASK-73560
branch
4 times, most recently
from
a06d72e
to
f6e2c6e
Compare
… English instead of Arabic - EXO-73560 - Meeds-io/meeds#2308. Before this change, when you set the language to Arabic as a plf admin and access the admin site, the platform settings menu is positioned on the left and is not fully displayed due to an overlap with the main settings block. After this change, the right to left display in the platform settings menu without overlap is displayed correctly.
|
mkrout
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when you set the language to Arabic as a plf admin and access the admin site, the platform settings menu is positioned on the left and is not fully displayed due to an overlap with the main settings block. After this change, the right to left display in the platform settings menu without overlap is displayed correctly.