fix: Link should be opened in new tab yet it opens in the same tab - EXO-71860 - Meeds-io/meeds#2214 #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XO-71860 - Meeds-io/meeds#2214. Before this change, when add a new node in space or home page of type link and select(New tab) in the option (Opens in) then add any link, save, click on the created node or click on ctrl+ the node having the link or any other node, two tabs are opened with the added link. After this change, current page is loaded nor redirected to the node link page and only one new tab is opened directing the node link page. (cherry picked from commit a8d449a)
mkrout
approved these changes
Jun 21, 2024
akhanfir
approved these changes
Jun 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when add a new node in space or home page of type link and select(New tab) in the option (Opens in) then add any link, save, click on the created node or click on ctrl+ the node having the link or any other node, two tabs are opened with the added link. After this change, current page is loaded nor redirected to the node link page and only one new tab is opened directing the node link page.
(cherry picked from commit a8d449a)