Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Link should be opened in new tab yet it opens in the same tab - EXO-71860 - Meeds-io/meeds#2214. #3917

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

akhanfir
Copy link
Contributor

Before this change, when add a new node in space or home page of type link and select(New tab) in the option (Opens in) then add any link, save, click on the created node or click on ctrl+ the node having the link or any other node, two tabs are opened with the added link. After this change, current page is loaded nor redirected to the node link page and only one new tab is opened directing the node link page.

…XO-71860 - Meeds-io/meeds#2214.

Before this change, when add a new node in space or home page of type link and select(New tab) in the option (Opens in) then add any link,
save, click on the created node or click on ctrl+ the node having the link or any other node, two tabs are opened with the added link. After this change, current page is loaded nor redirected to the node link page and only one new tab is opened directing the node link page.
@akhanfir akhanfir requested a review from mkrout June 20, 2024 12:22
@akhanfir akhanfir enabled auto-merge June 20, 2024 12:22
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Jun 20, 2024
@akhanfir akhanfir merged commit 840bf58 into feature/maintenance Jun 20, 2024
5 checks passed
@akhanfir akhanfir deleted the TASK-71860 branch June 20, 2024 12:27
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants