feat: No additional margin when hidden app - MEED-2924-Meeds-io/MIPs#103

 (#3195)

This change allow to add a new data attribute to check if all steps in the gattingStarted portlet are done so we add hidden class to the app parent.

(cherry picked from commit e24b613)

webapp/portlet/src/main/webapp/WEB-INF/jsp/portlet/gettingStarted.jsp

@@ -25,7 +25,7 @@
     }
 %>
 <div class="VuetifyApp">
-  <div style="" id="GettingStartedPortlet">
+  <div style="" id="GettingStartedPortlet" data-can-close="<%=canClose%>">
     <div data-app="true"
       class="v-application v-application--is-ltr theme--light" id="app">
       <div class="v-application--wrap">

webapp/portlet/src/main/webapp/vue-apps/getting-started/main.js

@@ -17,9 +17,8 @@ if (parentAppElement) {
       hideGettingStarted().then(() => parentElementToHide.classList.add('hidden'));
     });
   };
-} else {
-  const parentElementToHide = document.querySelector('#GettingStartedPortlet');
-  if (parentElementToHide) {
-    parentElementToHide.closest('.PORTLET-FRAGMENT').classList.add('hidden');
-  }
+}
+const parentElementToHide = document.querySelector('#GettingStartedPortlet');
+if (parentElementToHide && parentElementToHide.dataset.canClose === 'true') {
+  parentElementToHide.closest('.PORTLET-FRAGMENT').classList.add('hidden');
 }