Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SpaceId in Generated notifications to allow muting it - MEED-2598 - Meeds-io/MIPs#97 #391

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

boubaker
Copy link
Member

@boubaker boubaker commented Oct 5, 2023

This change will allow to mute kudos notifications added to a space. For now, the muting is disabled, but the spaceId is attached into the notification for future possible modifications.

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@boubaker boubaker enabled auto-merge (squash) October 5, 2023 14:09
@boubaker boubaker merged commit d9ff269 into develop-meed Oct 5, 2023
5 checks passed
@boubaker boubaker deleted the meed-mip-97-dev-meed branch October 5, 2023 14:10
exo-swf pushed a commit that referenced this pull request Oct 5, 2023
…D-2598 - Meeds-io/MIPs#97 (#389) (#391)

This change will allow to mute kudos notifications added to a space. For now, the muting is disabled, but the spaceId is attached into the notification for future possible modifications.
exo-swf pushed a commit that referenced this pull request Oct 5, 2023
…D-2598 - Meeds-io/MIPs#97 (#389) (#391)

This change will allow to mute kudos notifications added to a space. For now, the muting is disabled, but the spaceId is attached into the notification for future possible modifications.
exo-swf pushed a commit that referenced this pull request Oct 6, 2023
…D-2598 - Meeds-io/MIPs#97 (#389) (#391)

This change will allow to mute kudos notifications added to a space. For now, the muting is disabled, but the spaceId is attached into the notification for future possible modifications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants