Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Kudos Sending outside of activities - MEED-2476 - Meeds-io/meeds#1090 #347

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

boubaker
Copy link
Member

@boubaker boubaker commented Sep 9, 2023

Prior to this change, when sending a kudos outside of an activity, the Parent Entity Identifier is null while it was set as mandatory in Hibernate Entity Mapping. This change will ensure to use the exact same constraint as the ones made in database for this field, which is nullable.

…eeds#1090 (#346)

Prior to this change, when sending a kudos outside of an activity, the Parent Entity Identifier is null while it was set as mandatory in Hibernate Entity Mapping. This change will ensure to use the exact same constraint as the ones made in database for this field, which is nullable.
@boubaker boubaker enabled auto-merge (squash) September 9, 2023 08:02
@boubaker boubaker linked an issue Sep 9, 2023 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@boubaker boubaker merged commit f0cfc8a into develop Sep 11, 2023
5 checks passed
@boubaker boubaker deleted the meed-2476-develop branch September 11, 2023 07:12
exo-swf pushed a commit that referenced this pull request Sep 11, 2023
…eeds#1090 (#347)

Prior to this change, when sending a kudos outside of an activity, the Parent Entity Identifier is null while it was set as mandatory in Hibernate Entity Mapping. This change will ensure to use the exact same constraint as the ones made in database for this field, which is nullable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't send a kudos outiside an activity
2 participants