-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the ability to send a kudos from the composer - MEED-2071 - meeds-io/meeds#54 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayTekayaa
force-pushed
the
MEED-2071
branch
2 times, most recently
from
August 10, 2023 12:31
d89eb66
to
76944c0
Compare
boubaker
reviewed
Aug 10, 2023
<div | ||
v-if="isLinkedKudos" | ||
class="d-flex flex-row pl-4 mb-2 text-truncate kudosReceiverAttendeeItem"> | ||
<div v-if="composerDisplay"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need a dedicated component to define and inject into composer instead of reusing the existing one.
Suggested change
<div v-if="composerDisplay"> | |
<div> |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
boubaker
approved these changes
Aug 14, 2023
exo-swf
pushed a commit
that referenced
this pull request
Aug 16, 2023
…Meeds-io/meeds#54 (#320) This change will add the ability to send a kudos from the composer .
exo-swf
pushed a commit
that referenced
this pull request
Aug 21, 2023
…Meeds-io/meeds#54 (#320) This change will add the ability to send a kudos from the composer .
exo-swf
pushed a commit
that referenced
this pull request
Aug 23, 2023
…Meeds-io/meeds#54 (#320) This change will add the ability to send a kudos from the composer .
MayTekayaa
added a commit
that referenced
this pull request
Sep 8, 2023
…Meeds-io/meeds#54 (#320) This change will add the ability to send a kudos from the composer .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will add the ability to send a kudos from the composer .