Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete Asynchronous Kudos Comment deletion when canceled - MEED-2381 - Meeds-io/meeds#1039 #314

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

boubaker
Copy link
Member

Prior to this change, the kudos comment isn't deleted right after canceling the kudos. This change will make the deletion immediate and not asynchronous.

…2381 - Meeds-io/meeds#1039

Prior to this change, the kudos comment isn't deleted right after canceling the kudos. This change will make the deletion immediate and not asynchronous.
@boubaker boubaker enabled auto-merge (squash) July 24, 2023 17:39
@boubaker boubaker requested a review from AzmiTouil July 24, 2023 17:40
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@boubaker boubaker disabled auto-merge July 24, 2023 17:55
@boubaker boubaker merged commit 4b8d806 into develop Jul 24, 2023
3 checks passed
@boubaker boubaker deleted the meed-2381-develop branch July 24, 2023 17:57
exo-swf pushed a commit that referenced this pull request Jul 24, 2023
…2381 - Meeds-io/meeds#1039 (#314)

Prior to this change, the kudos comment isn't deleted right after canceling the kudos. This change will make the deletion immediate and not asynchronous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant