fix: Cleanup Event definition - Meeds-io/MIPs#64 (#91)

This change will delete usage of RuleRegistry service which has been deleted.
Meeds-io · Sep 25, 2023 · a430ff5 · a430ff5
1 parent 966a90f
commit a430ff5
Show file tree

Hide file tree

Showing 4 changed files with 6,480 additions and 9,220 deletions.
diff --git a/gamification-github-services/src/main/resources/conf/portal/configuration.xml b/gamification-github-services/src/main/resources/conf/portal/configuration.xml
@@ -60,7 +60,7 @@
           <property name="jobName" value="GitHubWebHookForceUpdate"/>
           <property name="groupName" value="Gamification"/>
           <property name="job" value="org.exoplatform.gamification.github.scheduled.GitHubWebHookForceUpdate"/>
-          <property name="expression" value="${io.meeds.gamification.GitHubWebHookForceUpdate.expression:0 * * * *}"/><!-- Every hour -->
+          <property name="expression" value="${io.meeds.gamification.GitHubWebHookForceUpdate.expression:0 0 * ? * * *}"/><!-- Every hour -->
         </properties-param>
       </init-params>
     </component-plugin>
@@ -98,11 +98,6 @@
       <set-method>addPlugin</set-method>
       <type>org.exoplatform.gamification.github.plugin.CommentTriggerPlugin</type>
     </component-plugin>
-    <component-plugin>
-      <name>issue_comment</name>
-      <set-method>addPlugin</set-method>
-      <type>org.exoplatform.gamification.github.plugin.CommentTriggerPlugin</type>
-    </component-plugin>
   </external-component-plugins>
 
   <import>jar:/conf/portal/gamification-github-connector-configuration.xml</import>

diff --git a/...b-services/src/main/resources/conf/portal/gamification-github-connector-configuration.xml b/...b-services/src/main/resources/conf/portal/gamification-github-connector-configuration.xml
@@ -20,65 +20,6 @@
                xsi:schemaLocation="http://www.exoplatform.org/xml/ns/kernel_1_2.xsd http://www.exoplatform.org/xml/ns/kernel_1_2.xsd"
                xmlns="http://www.exoplatform.org/xml/ns/kernel_1_2.xsd">
 
-  <external-component-plugins>
-    <target-component>io.meeds.gamification.service.RuleRegistry</target-component>
-    <component-plugin>
-      <name>rule.PushCode</name>
-      <set-method>addPlugin</set-method>
-      <type>io.meeds.gamification.plugin.RuleConfigPlugin</type>
-      <init-params>
-        <value-param>
-          <name>rule-event</name>
-          <value>pushCode</value>
-        </value-param>
-      </init-params>
-    </component-plugin>
-    <component-plugin>
-      <name>rule.CreatPullRequest</name>
-      <set-method>addPlugin</set-method>
-      <type>io.meeds.gamification.plugin.RuleConfigPlugin</type>
-      <init-params>
-        <value-param>
-          <name>rule-event</name>
-          <value>creatPullRequest</value>
-        </value-param>
-      </init-params>
-    </component-plugin>
-    <component-plugin>
-      <name>rule.ReviewPullRequest</name>
-      <set-method>addPlugin</set-method>
-      <type>io.meeds.gamification.plugin.RuleConfigPlugin</type>
-      <init-params>
-        <value-param>
-          <name>rule-event</name>
-          <value>reviewPullRequest</value>
-        </value-param>
-      </init-params>
-    </component-plugin>
-    <component-plugin>
-      <name>rule.CommentPullRequest</name>
-      <set-method>addPlugin</set-method>
-      <type>io.meeds.gamification.plugin.RuleConfigPlugin</type>
-      <init-params>
-        <value-param>
-          <name>rule-event</name>
-          <value>commentPullRequest</value>
-        </value-param>
-      </init-params>
-    </component-plugin>
-    <component-plugin>
-      <name>rule.PullRequestValidated</name>
-      <set-method>addPlugin</set-method>
-      <type>io.meeds.gamification.plugin.RuleConfigPlugin</type>
-      <init-params>
-        <value-param>
-          <name>rule-event</name>
-          <value>pullRequestValidated</value>
-        </value-param>
-      </init-params>
-    </component-plugin>
-  </external-component-plugins>
-
   <external-component-plugins>
     <target-component>io.meeds.gamification.service.EventRegistry</target-component>
     <component-plugin>
@@ -311,10 +252,8 @@
         </value-param>
       </init-params>
     </component-plugin>
-
   </external-component-plugins>
 
-
   <external-component-plugins>
     <target-component>io.meeds.gamification.service.BadgeRegistry</target-component>
     <component-plugin>