Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 3.6] Remove definitions of legacy symbols #9640

Open
wants to merge 2 commits into
base: mbedtls-3.6
Choose a base branch
from
Open

[Backport 3.6] Remove definitions of legacy symbols #9640

wants to merge 2 commits into from

Conversation

eleuzi01
Copy link
Contributor

@eleuzi01 eleuzi01 commented Sep 26, 2024 •
edited by ronald-cron-arm
Loading

Description

This only includes changes to the submodule

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 added enhancement component-crypto Crypto primitives and low-level interfaces size-xs Estimated task size: extra small (a few hours at most) labels Sep 26, 2024
@eleuzi01 eleuzi01 mentioned this pull request Sep 26, 2024
Open
6 tasks
@eleuzi01 eleuzi01 added needs-ci Needs to pass CI tests and removed needs-ci Needs to pass CI tests labels Sep 26, 2024
ronald-cron-arm
ronald-cron-arm previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

gabor-mezei-arm
gabor-mezei-arm previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabor-mezei-arm gabor-mezei-arm added the approved Design and code approved - may be waiting for CI or backports label Sep 30, 2024
ronald-cron-arm added a commit to Mbed-TLS/mbedtls-framework that referenced this pull request Sep 30, 2024
@ronald-cron-arm
Merge pull request #34 from eleuzi01/replace-ecc-keys
33ac133 
Replace MBEDTLS_PK_HAVE_ECC_KEYS with PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY

Validated for dev by the CI of Mbed-TLS/mbedtls#9492, for 3.6 by the CI of Mbed-TLS/mbedtls#9640.
@ronald-cron-arm ronald-cron-arm mentioned this pull request Sep 30, 2024
Merged
@eleuzi01
Update submodule
9204c2b 
Signed-off-by: Elena Uziunaite <[email protected]>
ronald-cron-arm
ronald-cron-arm approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm ronald-cron-arm added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

@gabor-mezei-arm gabor-mezei-arm Awaiting requested review from gabor-mezei-arm

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
component-crypto Crypto primitives and low-level interfaces enhancement needs-review Every commit must be reviewed by at least two team members, size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eleuzi01 @ronald-cron-arm @gabor-mezei-arm