Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rljacobson's heursitic on Unicode #78

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

rocky
Copy link
Member

@rocky rocky commented Sep 13, 2024

@rljacobson here are your heuristics added as comments to named-characters.yml

@rocky rocky requested a review from mmatera September 13, 2024 17:09
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky
Copy link
Member Author

rocky commented Sep 17, 2024

Merging in now. @rljacobson if you have any comments, questions, or concerns feel free to mention and we'll fix down the line.

@rocky rocky merged commit 9cc2050 into master Sep 17, 2024
12 checks passed
@rocky rocky deleted the rljacobson-heursitics-note branch September 17, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants