Fixing JS search #205
Merged
Fixing JS search #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs the doc-code-rebased-rebased branch of Mathics core.
mmatera
commented
Aug 4, 2024
| @@ -61,7 +60,6 @@ function loadDoc(page) { | |||
|
|
|||
| function showDoc() { | |||
| const docLink = document.getElementById('doclink'); | |||
| loadDoc(''); | |||
There was a problem hiding this comment.
The problem with reloading the documentation page here is that it breaks the search bar.
mmatera
commented
Aug 4, 2024
| @@ -98,6 +96,7 @@ function toggleDoc() { | |||
| if (document.getElementById('doc').style.display !== 'none') { | |||
| hideDoc(); | |||
| } else { | |||
| loadDoc("/"); | |||
There was a problem hiding this comment.
here do not seem to interfere
|
This now is better, but we are still missing some sections. I suspect we aren't searching all sections, like subsections or guide sections or something like that. |
and other small tweaks
|
LGTM - With recent merge into this branch things work for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with the search bar.