Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplementing eval_makeboxes. step 1 #699

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Dec 28, 2022

This is the first step in my proposal of refactoring MakeBoxes. The main change here is that MakeBoxes rules are applied in mathics.eval.makeboxes.eval_makeboxes instead of the mathics.core.expression.rewrite_apply_eval_step. In a next step, makeboxes rules are going to be stored not as downvalues of the MakeBoxes symbol, but as format values.

@mmatera mmatera marked this pull request as draft December 30, 2022 17:39
@rocky
Copy link
Member

rocky commented Dec 30, 2022

@mmatera I do not intent to look at this until after the next release. Actually, in some respect this is kind of a distraction right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants