basic implementation of DisplayForm #604
Conversation
mathics/builtin/forms/output.py
Outdated
| in_outputforms = True | ||
| summary_text = "render low-level box structures" | ||
|
|
||
| def apply_makeboxes(self, expr, f, evaluation): |
There was a problem hiding this comment.
apply -> eval in new code please.
| @@ -394,6 +394,10 @@ def apply_general(self, expr, f, evaluation): | |||
| """MakeBoxes[expr_, | |||
| f:TraditionalForm|StandardForm|OutputForm|InputForm|FullForm]""" | |||
| if isinstance(expr, BoxElementMixin): | |||
| # If we are inside a DisplayForm block, | |||
| # BoxElementMixin are not processed. | |||
| if evaluation.in_display_form: | |||
There was a problem hiding this comment.
Can this be handled by some sort of HoldForm attribute?
I know DisplayForm doesn't have the HoldForm attribute, but if the attribute mechanism were hooked into somehow we wouldn't need to add a special flag and test.
There was a problem hiding this comment.
I don't think so. In the first place, I guess that in WMA , it does not have that attribute for a reason. But, I also tried to avoid the new attribute, and I could not figure out how to do that without changing more parts of the code.
There was a problem hiding this comment.
Ok - I'd like to check on this. Doing this kind of thing feels weird.
There was a problem hiding this comment.
Thinking about it again, one alternative would be to set a symbol in a private context, and then instead of looking at that property, look at the value of the symbol. This could have the advantage to make easy to replace the Python code that implements MakeBoxes by WL code. But in the end, it would be the same idea.
There was a problem hiding this comment.
To start out, I believe we should be following the way that can be written in WL. This keeps us from inventing mechanisms, and flags and so on. Also, since WL follows a certain logic, makes it more likely we will go with the natural flow here, without having to consider specially edge cases. They are probably the ones that WL has set up.
If later we need to get things faster then starting with the logical flow is better than some guessed version.
There was a problem hiding this comment.
As I think I mentioned on the other PR, TagBox might be used by DisplayForm and that is probably a mechanism by which we get special behavior.
See https://reference.wolfram.com/language/ref/TraditionalForm.html
This PR provides a basic / preliminar implementation for
DisplayForm.