Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-28153: use static control dependencies adjusted by autobake-deb.sh #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grooverdan
Copy link
Member

This solves a few debian:9 / ubuntu:18.04 problems.

At the moments, it's depending on MariaDB/server#2064 merged up to 10.7 where the deb build generates from.

For the moment I've tested with:

$ buildah bud --build-arg  mariadb_branch=bb-10.5-danielblack-MDEV-28153-deb-explict-deps-salsa-postfix --build-arg base_image=ubuntu:18.04 --tag bb:u1804 -f debian.Dockerfile

And

$ buildah bud --build-arg  mariadb_branch=bb-10.5-danielblack-MDEV-28153-deb-explict-deps-salsa-postfix --build-arg base_image=debian:9 --tag bb:deb9 -f debian.Dockerfile

Which generates an image.

There's a small gap that it doesn't (yet?) pull columnstore dependencies.

grooverdan added a commit to grooverdan/mariadb-server that referenced this pull request Apr 6, 2022
Without doing the full build.

Autobake now includes a dependency on lsb-release.

As the BB CI images
(https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/ci_build_images/debian.Dockerfile)
have explicit dependencies, there's no point maintaining them in
two places. We don't want do the full autobake-deb.sh there, just enough
to have the control file containing the correct dependencies.

Helps: MariaDB/mariadb.org-tools#130
grooverdan added a commit to grooverdan/mariadb-server that referenced this pull request Apr 7, 2022
Without doing the full build.

Autobake now includes a dependency on lsb-release.

As the BB CI images
(https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/ci_build_images/debian.Dockerfile)
have explicit dependencies, there's no point maintaining them in
two places. We don't want do the full autobake-deb.sh there, just enough
to have the control file containing the correct dependencies.

Helps: MariaDB/mariadb.org-tools#130
grooverdan added a commit to grooverdan/mariadb-server that referenced this pull request Apr 7, 2022
Without doing the full build.

Autobake now includes a dependency on lsb-release.

As the BB CI images
(https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/ci_build_images/debian.Dockerfile)
have explicit dependencies, there's no point maintaining them in
two places. We don't want do the full autobake-deb.sh there, just enough
to have the control file containing the correct dependencies.

Helps: MariaDB/mariadb.org-tools#130
grooverdan added a commit to MariaDB/server that referenced this pull request Apr 7, 2022
Without doing the full build.

Autobake now includes a dependency on lsb-release.

As the BB CI images
(https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/ci_build_images/debian.Dockerfile)
have explicit dependencies, there's no point maintaining them in
two places. We don't want do the full autobake-deb.sh there, just enough
to have the control file containing the correct dependencies.

Helps: MariaDB/mariadb.org-tools#130
@grooverdan
Copy link
Member Author

note we need to consider if a java compiler as I got different results like this. The corp stretch builder had a java compiler old enough to compile these files. They are currently omitted because the build infrastructure for packages isn't consistent.

Given the java dependency isn't in debian/control as a build dep, this isn't suprising and maybe it need to be fixed there, however we do no have a difference between rpm and debs (well, has existed for a while).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants