Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.21.12 #4421

Merged
merged 2 commits into from
Sep 28, 2024
Merged

V0.21.12 #4421

merged 2 commits into from
Sep 28, 2024

Conversation

SimonDanisch
Copy link
Member

Description

Fixes # (issue)

Add a description of your PR here.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Sep 28, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.41s (4.39, 4.48) 0.03+- 106.01ms (103.02, 108.02) 1.74+- 463.03ms (453.00, 472.96) 7.20+- 9.18ms (8.94, 9.41) 0.20+- 25.78ms (25.64, 25.95) 0.13+-
master 4.44s (4.40, 4.47) 0.03+- 106.46ms (103.36, 108.09) 2.05+- 471.46ms (465.81, 477.21) 5.24+- 9.19ms (9.00, 9.45) 0.18+- 25.96ms (25.77, 26.18) 0.16+-
evaluation 1.01x invariant, -0.03s (-0.80d, 0.16p, 0.03std) 1.00x invariant, -0.45ms (-0.24d, 0.66p, 1.89std) 1.02x faster ✓, -8.43ms (-1.34d, 0.03p, 6.22std) 1.00x invariant, -0.02ms (-0.08d, 0.88p, 0.19std) 1.01x faster ✓, -0.18ms (-1.19d, 0.05p, 0.15std)
CairoMakie 4.15s (4.11, 4.28) 0.06+- 107.31ms (103.84, 114.79) 3.62+- 168.20ms (163.68, 173.50) 3.28+- 9.33ms (9.07, 9.77) 0.30+- 1.14ms (1.13, 1.15) 0.01+-
master 4.15s (4.10, 4.20) 0.04+- 105.80ms (104.95, 106.55) 0.68+- 168.14ms (165.21, 181.07) 5.73+- 9.59ms (9.46, 9.70) 0.07+- 1.13ms (1.12, 1.14) 0.01+-
evaluation 1.00x invariant, 0.0s (0.05d, 0.93p, 0.05std) 0.99x invariant, 1.51ms (0.58d, 0.32p, 2.15std) 1.00x invariant, 0.05ms (0.01d, 0.98p, 4.51std) 1.03x invariant, -0.26ms (-1.17d, 0.07p, 0.19std) 0.99x slower X, 0.01ms (1.47d, 0.02p, 0.01std)
WGLMakie 4.74s (4.67, 4.81) 0.05+- 108.70ms (106.68, 119.05) 4.57+- 9.06s (8.98, 9.29) 0.11+- 11.54ms (11.27, 12.05) 0.25+- 118.44ms (115.35, 120.96) 2.24+-
master 4.68s (4.66, 4.72) 0.02+- 107.90ms (105.25, 114.46) 3.20+- 9.47s (9.28, 9.69) 0.14+- 11.64ms (11.38, 12.40) 0.37+- 120.33ms (117.04, 122.21) 2.01+-
evaluation 0.99x slower X, 0.05s (1.46d, 0.02p, 0.03std) 0.99x invariant, 0.8ms (0.20d, 0.71p, 3.89std) 1.05x faster ✓, -0.41s (-3.27d, 0.00p, 0.12std) 1.01x invariant, -0.1ms (-0.33d, 0.55p, 0.31std) 1.02x invariant, -1.89ms (-0.89d, 0.12p, 2.13std)

@SimonDanisch SimonDanisch merged commit 75eb38e into master Sep 28, 2024
18 checks passed
@SimonDanisch SimonDanisch deleted the v0.21.12 branch September 28, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants