Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port uvloop to Python 3.12 #570

Merged
merged 17 commits into from
Oct 10, 2023
Merged

Port uvloop to Python 3.12 #570

merged 17 commits into from
Oct 10, 2023

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Oct 8, 2023

Fixes #569

@1st1
Copy link
Member Author

1st1 commented Oct 8, 2023

While working on this I stumbled upon what seems to be an asyncio regression in 3.12. Good news that uvloop doesn't have this regression. Bad news -- our tests that test compliance with asyncio are now failing (we should backport our functional tests to the Python project, they increase test coverage by a lot!)

python/cpython#79033 (comment)

@1st1 1st1 requested a review from fantix October 8, 2023 02:05
setup.py Outdated Show resolved Hide resolved
@1st1 1st1 marked this pull request as ready for review October 8, 2023 13:27
@1st1 1st1 force-pushed the 12 branch 3 times, most recently from de6fd30 to 2783939 Compare October 8, 2023 16:42
README.rst Outdated Show resolved Hide resolved
@1st1 1st1 force-pushed the 12 branch 5 times, most recently from 69e3e54 to e1c1e69 Compare October 9, 2023 10:48
This partially reverts commit 247fb17.
@fantix fantix merged commit 9f82bd7 into master Oct 10, 2023
13 checks passed
@fantix fantix deleted the 12 branch October 10, 2023 00:28
@AntonOfTheWoods
Copy link

Is there an ETA on a release?

fantix added a commit that referenced this pull request Oct 12, 2023
Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)
@fantix fantix mentioned this pull request Oct 12, 2023
fantix added a commit that referenced this pull request Oct 13, 2023
Changes
=======

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)

* Upgrade libuv to v1.46.0 (#571)
  (by @fantix in 2e1978c for #571)

Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we update cython and make uvloop compatible with python 3.12 please?
4 participants