Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 compatibility #105

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Python 3.12 compatibility #105

merged 1 commit into from
Jul 21, 2023

Conversation

elprans
Copy link
Member

@elprans elprans commented Jul 21, 2023

Also, drop 3.6 and 3.7 as unsupported.

Fixes: #104
Closes: #97
Closes: #100
Closes: #103

Also, drop 3.6 and 3.7 as unsupported.

Fixes: #104
Closes: #97
Closes: #100
Closes: #103

Co-authored-by: Petr Vaněk <[email protected]>
Co-authored-by: Anton Agestam <[email protected]>
@elprans elprans mentioned this pull request Jul 21, 2023
@elprans elprans merged commit f797822 into master Jul 21, 2023
21 checks passed
@elprans elprans deleted the python-12 branch July 21, 2023 22:30
#ifdef HAVE_STDARG_PROTOTYPES
va_start(vargs, format);
#else
#if PY_VERSION_HEX < 0x030C00A1 && !defined(HAVE_STDARG_PROTOTYPES)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could probably just only have the 2 arg format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People seem to be building immutables on odd platforms, so I'm reluctant to drop this.

@@ -65,16 +65,16 @@
version=VERSION,
description='Immutable Collections',
long_description=readme,
python_requires='>=3.6',
python_requires='>=3.7',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 3.8, since 3.7 was also dropped.

elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
@elprans elprans mentioned this pull request Aug 14, 2023
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.12 support
3 participants