Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comparison with NaNs #285

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix comparison with NaNs #285

merged 1 commit into from
Aug 16, 2023

Conversation

shouples
Copy link
Collaborator

@shouples shouples commented Aug 16, 2023

Previous tests broke for geodataframes since comparing the geometry columns that contained Point(value, NaN) would evaluate to false and not match correctly.
image

FAILED tests/test_renderable_types.py::TestRenderableTypes::test_non_pandas_dataframes[simple-True-geopandas] - AssertionError: assert 'unk_datafram...4d0eb41b576e7' == 'test_df'
    - test_df
    + unk_dataframe_94faf76d674849278374d0eb41b576e7
assert False

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #285 (3688ad9) into main (69b04b8) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          84       84           
  Lines        3026     3027    +1     
=======================================
+ Hits         2541     2542    +1     
  Misses        485      485           
Files Changed Coverage Δ
src/dx/utils/tracking.py 97.75% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40113d...3688ad9. Read the comment docs.

@shouples shouples requested a review from a team August 16, 2023 13:57
@shouples shouples merged commit 6eaf6d4 into main Aug 16, 2023
7 checks passed
@shouples shouples deleted the djs/fix-comparisons branch August 16, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants