Fix incoming build error in rtd #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 69.57% 69.57%
=======================================
Files 179 179
Lines 15036 15036
=======================================
Hits 10461 10461
Misses 4575 4575 ☔ View full report in Codecov by Sentry. |
robertodr
reviewed
Oct 2, 2023
.readthedocs.yml
Outdated
| build: | ||
| os: ubuntu-22.04 | ||
| tools: | ||
| python: "3.6" |
There was a problem hiding this comment.
I think we can use 3.9 or later, also because Python 3.6 is unmaintained.
There was a problem hiding this comment.
well, using 3.9 broke RTD 🤔
There was a problem hiding this comment.
It's some bug in sphinx_rtd_theme with the latest sphinx. Pinned the latter to <7 and now things work.
robertodr
reviewed
Oct 2, 2023
|
I'll then merge this, @robertodr could you check the PR on MRCPP. it is the same changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the key
build.oswill start being a requirement soon (see link )Hopefully this fixes any issues