Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported python versions #856

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

altheaden
Copy link
Collaborator

Python version 3.8 has now been dropped from conda-forge, and 3.12 has been added. This PR just updates the related checks and files to be consistent with those supported versions.

Checklist

  • Developer's Guide has been updatedbuilding_docs.html) and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@altheaden altheaden requested a review from xylar September 4, 2024 17:15
@altheaden altheaden force-pushed the update-supported-python-versions branch from 97f4f6d to 8d4dc93 Compare September 4, 2024 17:19
@altheaden
Copy link
Collaborator Author

@xylar as you will see in the changed files, I deleted and added some files in the ci folder. I just guessed based on the existing files that the only change within these files would be the version number, but you should definitely look that over in case it should be different. Also, please take a look at my change in the developer's guide, it's very small but I want to make sure that it's accurate.

@altheaden
Copy link
Collaborator Author

Testing

I haven't done any testing yet, as I'm not sure if any of these changes would affect building/running compass. I am happy to run the PR suite if that's desired, but I'll hold off for now.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! One tiny change.

@@ -217,7 +217,7 @@ Optional flags
Check to make sure expected commands are present

``--python``
Select a particular python version (the default is currently 3.8)
Select a particular python version (the default is currently 3.9)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Select a particular python version (the default is currently 3.9)
Select a particular python version (the default is currently 3.12)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very out of date.

@xylar xylar self-assigned this Sep 4, 2024
@xylar xylar added the dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script label Sep 4, 2024
@xylar
Copy link
Collaborator

xylar commented Sep 4, 2024

@altheaden, these could in theory affect tests but I'm not worried. As long as CI passes, I think we can consider that sufficient testing.

@altheaden altheaden force-pushed the update-supported-python-versions branch from 8d4dc93 to 6aa959c Compare September 4, 2024 18:39
@altheaden
Copy link
Collaborator Author

@xylar Done!

@xylar
Copy link
Collaborator

xylar commented Sep 4, 2024

Thanks @altheaden!

@xylar xylar merged commit e056690 into MPAS-Dev:main Sep 4, 2024
5 checks passed
@xylar xylar deleted the update-supported-python-versions branch September 4, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants