Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added linear dz in vertical grid #724

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alicebarthel
Copy link
Contributor

Added option for linearly increasing dz in the ocean vertical grid (needed for the baroclinic gyre case)

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • The E3SM-Project submodule has been updated with relevant E3SM changes
  • The MALI-Dev submodule has been updated with relevant MALI changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes
  • New tests have been added to a test suite

@cbegeman
Copy link
Collaborator

@alicebarthel The changes visually look good to me but I haven't tested them. Do you mind if I review and test this and the baroclinic gyre PR together, or do you have another idea in mind?

@alicebarthel
Copy link
Contributor Author

@cbegeman whatever works better for you. Xylar and I had talked about making a separate branch and PR for the vertical grid changes, but since most of the changes were already updated by Xylar, this PR may be overkill.

@xylar
Copy link
Collaborator

xylar commented Nov 1, 2023

@alicebarthel, yes, exactly. I thought the renaming still needed to happen but that's already on main so maybe this PR isn't needed after all. Sorry about that!

@alicebarthel
Copy link
Contributor Author

No worries. I started the dev on a separate branch based on this (and rebased on yesterday's master). So maybe I'll switch this to a draft PR and make a bigger PR with the test case when I am ready.

@alicebarthel alicebarthel marked this pull request as draft November 1, 2023 16:17
@xylar
Copy link
Collaborator

xylar commented Nov 1, 2023

You don't need to make a new PR for the test case, you just need to force-push to the branch you used for #547. I would prefer that to a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants