Refactor land-ice mesh generation test cases #590
Commits on Apr 11, 2023
-
Move build_cell_width() to compass.landice.mesh
Move build_cell_width() to compass.landice.mesh to greatly reduce code redundancy between all mesh-generating test cases.
-
Move most jigsaw and mpas-tools operations to compass.landice.mesh
Move most jigsaw and mpas-tools operations to compass.landice.mesh.build_MALI_mesh() to greatly reduce redundant code between mesh generation test cases.
-
Standardize mesh generation test case and config section names
Standardize mesh generation test case and config section names, using mesh_gen for the test case and 'mesh' for the config section. All .cfg files pertaining only to mesh generation have been moved into the mesh_gen modules.
-
Update landice api in developers guide
Update landice api in developers guide to include renamed methods and classes, and new functions in landice.mesh.
-
Fix output file name in humboldt mesh_gen test case
Fix inconsistent usage of Humboldt.nc and Humboldt_1to10km.nc that caused an error at the end of the test case.
-
Add make_region_masks() function to landice.mesh.
Add make_region_masks() function to landice.mesh, and add this capability for Greenland as well as Antarctica.
-
Fix netcdf format and engine definitions
Fix netcdf format and engine definitions, which for some reason need to be called as mpas_tools.io.default_engine rather than using: from mpas_tools.io import default_engine. The latter approach returned a None type variable, which threw an error when passed to compute_mpas_region_masks.
-
Fix culling of Antarctic islands
Fix path to gridded dataset to use for building MALI mesh, in order to properly remove disconnected islands from the mesh.
-
Update documentation for compass.landice.mesh
Add compass.landice.mesh to framework documentation, and update some doc-strings.
-
Fix a few typos after building docs
Fix a few typos that only became apparent after building docs.
-
Update file-change-action to 1.2.4
This should reportedly fix: ``` Error: There was an issue sorting changed files from Github. Exception: { "error": "500/TypeError", "from": "sortChangedFiles", "message": "There was an issue sorting files changed.", "payload": "{}" } ``` See: trilom/file-changes-action#104 -
Change function names to all lowercase
Change function names to all lowercase in compass.landice.mesh.
-
Update Users and Developers guides after code review
Remove extraneous information from Users Guide. Add explanation of defining x/y bounds in example config file.
-
Clean up doc-strings and add required config options
Clean up doc-strings and add a list of required config options for each function in compass/landice/mesh.py that requires section_name as a parameter. Refer to the Users and Developers guides for more information on the meaning of the config options.
-
Add a few more required config parameters to doc-strings.
Add a few more required config parameters to doc-strings.
-
Allow a mix of user-defined and dataset-defined bounds
Allow the user to define the bounds around a regional domain with any combination of floats and 'None'. For example, a config file that contained ``x_min = 'None'; x_max = 1.0e6; y_min = -1.0e6; y_max = 'None'`` would use you left and top boundaries of the gridded dataset, but also the user-defined values for the right and bottom boundaries.
-
Small clean-up from code review
Remove redundant use of ``flood_mask == 0`` Co-authored-by: Xylar Asay-Davis <[email protected]>
-
Remove unnecessary calls to logger.info()
Remove unnecessary calls to logger.info(), as check_call already takes care of writing the commands to the log file.
