Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-release of new services version #230

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Pre-release of new services version #230

wants to merge 6 commits into from

Conversation

AlexFernandes-MOVAI
Copy link
Contributor

@AlexFernandes-MOVAI AlexFernandes-MOVAI commented Jul 31, 2023 •
edited
Loading

Fixes #

Proposed Changes

  • DP-1073: Have our public containers in github registry
  • DP-1104: Update the services versions in CE after 2.4 reach stable state
  • DP-1017: [CE] Linting check is breaking
  • Make sure you are opening from a topic/feature/bugfix branch
  • Ensure that the PR title represents the desired changes
  • Ensure that the PR description detail the desired changes
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

AlexFernandes-MOVAI and others added 5 commits July 24, 2023 15:45
@AlexFernandes-MOVAI
CICD : fix DeployOnMergeMain.yml with latest agent image
bfd2145
@dependabot @MithunKinarullathil @AlexFernandes-MOVAI
Bump isbang/compose-action from 1.4.1 to 1.5.0 (#226)
e837995 
* Bump isbang/compose-action from 1.4.1 to 1.5.0

Bumps [isbang/compose-action](https://github.com/isbang/compose-action) from 1.4.1 to 1.5.0.
- [Release notes](https://github.com/isbang/compose-action/releases)
- [Commits](hoverkraft-tech/compose-action@v1.4.1...v1.5.0)

---
updated-dependencies:
- dependency-name: isbang/compose-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update DeployOnMergeMain.yml

* Update ros-builldtools to v2.0.7

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Mithun Kinarullathil <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Fernandes <[email protected]>
@mariana-dias-alves @MithunKinarullathil
@github-actions @AlexFernandes-MOVAI
Dp-1104 update service settings in docker compose (#225)
df81e2f 
* Updated simulator and haproxy images to latest.

* Changing image versions to match manifest of ee-platform version 2.4.0-64

* Delete extra space in docker-compose.yml line 188

* Revert "Changing image versions to match manifest of ee-platform version 2.4.0-64"

This reverts commit 97f0a63.

* Updating backend version to match ee platform

* Update movai-ide-ce to latest version

* Update Spawner container image and necessary dependency packages

* Update ros-master container image

* Update ros-tools container image

* Update Simulator Container Image to latest version

* Update curl call for movai API

* Update curl call for movai API

* Increase authentication check duration

* Update authentication url

* Add env variables for user and passwrd

* Fix global variable bug

* Troubleshooting env variable bug

* Troubleshooting env variable bug

* Troubleshooting env variable bug

* Troubleshooting env variable bug

* Troubleshooting env variable bug

* Troubleshooting env variable bug

* Troubleshooting env variable bug

* Troubleshooting env variable bug

* Make credentials secret

---------

Co-authored-by: mithun <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: OttoMation-Movai <[email protected]>
@MithunKinarullathil @github-actions
Update README, add --all arg to movai-flow-reset script (#224)
63f5fe8 
* Update README.
Add --images flag to remove the images as well in movai-flow-reset.

* Update README.md

- Add corrections from Alex

* Use --all instead of --images for removing the docker images.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mariana-dias-alves @github-actions @AlexFernandes-MOVAI
DP-1104 - update service settings using ghcr (#229)
47c8160 
* Update redis image registry to GHCR

* Update haproxy image registry to GHCR

* Update ros-master image registry to GHCR

* Update ros-tools image registry to GHCR

* Update backend image registry to GHCR

* Update spawner image registry to GHCR

* çast version of flow-initiator

* fix CICD container version

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: OttoMation-Movai <[email protected]>
@AlexFernandes-MOVAI AlexFernandes-MOVAI added 4.0.0 Backend Refactor, FE updates, Logging UI pre-release Pull requests that group merges for a pre-release labels Jul 31, 2023
mariana-dias-alves
mariana-dias-alves requested changes Aug 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@MithunKinarullathil
Update README.md
98527e6 
- Update default user and pass
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

MithunKinarullathil
MithunKinarullathil requested changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@MithunKinarullathil MithunKinarullathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing I found a list of critical bugs we need to solve before merging this.

@AlexFernandes-MOVAI
Copy link
Contributor Author

2 actions needed:

  • add infos in the changelog
  • check we can give a alphasuffix to debian version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MithunKinarullathil MithunKinarullathil MithunKinarullathil requested changes

@mariana-dias-alves mariana-dias-alves mariana-dias-alves approved these changes

@PedroCristovao-Movai PedroCristovao-Movai Awaiting requested review from PedroCristovao-Movai

@diasnad diasnad Awaiting requested review from diasnad

@Mograbi Mograbi Awaiting requested review from Mograbi

Requested changes must be addressed to merge this pull request.

Assignees

@MithunKinarullathil MithunKinarullathil

Labels
4.0.0 Backend Refactor, FE updates, Logging UI pre-release Pull requests that group merges for a pre-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexFernandes-MOVAI @MithunKinarullathil @mariana-dias-alves