FP-2932: Save doesn't work well in split screen #355
Conversation
…work well in split screen
|
Looks good. Well done. |
|
I'm a bit reluctant because it might be too many changes for the next reviewer. And I'm a bit blocked by too many PRs in review. |
| @@ -79,16 +80,15 @@ const FlowSearch = props => { | |||
| className={classes.searchInputText} | |||
| autoFocus | |||
| InputProps={{ | |||
| ...params.InputProps, | |||
There was a problem hiding this comment.
What happened to other params.InputProps that might be passed here?
There was a problem hiding this comment.
Why pass them? They aren't used.
| } | ||
| }); | ||
|
|
||
| window.keybinds = keybinds; |
There was a problem hiding this comment.
Why are we storing the keybinds in the window?
There was a problem hiding this comment.
For debug purposes. So we can easily check which are the bound keybindings without changing the code.
It only brings benefits and not cons to my knowledge
| SHORTCUTS: "ctrl+alt+home", | ||
| SHORTCUTS: "Control+Alt+Home", |
There was a problem hiding this comment.
Because we use vanilla keybind names now. It has to do with the implementation having no dependencies
| @@ -0,0 +1,64 @@ | |||
| import { useMemo } from "react"; | |||
|
What you've stated does not happen to me |
quirinpa
force-pushed
the
FP-2932-save-doesnt-work-well-in-split-screen
branch
from
c7e83f5
to
de50aff
Compare
…rk-well-in-split-screen
|
Needs also: https://github.com/MOV-AI/frontend-npm-ide/pull/618