Merge pull request #187 from MOV-AI/dev

New release

CHANGELOG.md

@@ -1,5 +1,6 @@
 # 1.0.0 --installs on--> 2.4 IDE-EE / 3.1 IDE-CE
 
+- [FP-2539 - Reset bookmarks when we change active tab](https://movai.atlassian.net/browse/FP-2539)
 - [FP-2527 - Preventing the reload of a new doc when it's closed](https://movai.atlassian.net/browse/FP-2527)
 - [FP-2216 - IDE- black screen after changing resolution](https://movai.atlassian.net/browse/FP-2216)
 - [FP-2542 - Removed code that prevented flow validations from running](https://movai.atlassian.net/browse/FP-2542)

package.json

@@ -2,9 +2,6 @@
   "name": "@mov-ai/mov-fe-lib-ide",
   "version": "1.0.0-57",
   "main": "./dist/index.js",
-  "publishConfig": {
-    "registry": "https://npm.pkg.github.com/mov-ai"
-  },
   "repository": {
     "type": "git",
     "url": "https://github.com/MOV-AI/frontend-npm-lib-ide.git"
@@ -53,7 +50,7 @@
     "@material-ui/icons": ">=4.11.2",
     "@material-ui/lab": ">=4.0.0-alpha.60",
     "@material-ui/styles": ">=4.11.4",
-    "@mov-ai/mov-fe-lib-core": "^1.1.2-9",
+    "@mov-ai/mov-fe-lib-core": "^1.1.2-26",
     "@mov-ai/mov-fe-lib-react": "^1.1.2-23",
     "@tty-pt/styles": "^0.0.3-11",
     "react": ">=16.14.0",
@@ -74,7 +71,7 @@
     "@material-ui/icons": ">=4.11.2",
     "@material-ui/lab": ">=4.0.0-alpha.60",
     "@material-ui/styles": ">=4.11.4",
-    "@mov-ai/mov-fe-lib-core": "^1.1.2-9",
+    "@mov-ai/mov-fe-lib-core": "^1.1.2-26",
     "@mov-ai/mov-fe-lib-react": "^1.1.2-24",
     "@storybook/addon-actions": "^6.5.12",
     "@storybook/addon-essentials": "^6.5.12",

src/editors/_shared/hooks/DataTypes/types/BooleanType.js

@@ -11,6 +11,7 @@ class BooleanType extends DataType {
   default = false;
 
   editComponent = (props, mode = "row") => {
+    this.label = props.label ?? this.label;
     let pyValue = this.toString(props.rowData.value).toLowerCase();
     const editor = {
       row: () => this.booleanEditComponent(props, pyValue),
@@ -82,6 +83,7 @@ class BooleanType extends DataType {
 
     return (
       <Checkbox
+        data-testid={"Type=boolean-" + this.label}
         color={"primary"}
         style={{ width: "fit-content" }}
         checked={parsedValue}

src/engine/ReactPlugin/EditorReactPlugin.js

@@ -1,5 +1,6 @@
 import React, { forwardRef, useCallback, useEffect, useRef } from "react";
 import { Utils } from "@mov-ai/mov-fe-lib-core";
+import PluginManagerIDE from "../PluginManagerIDE/PluginManagerIDE";
 import withAlerts from "../../decorators/withAlerts";
 import withKeyBinds from "../../decorators/withKeyBinds";
 import withMenuHandler from "../../decorators/withMenuHandler";
@@ -76,7 +77,7 @@ export function withEditorPlugin(ReactComponent, methods = []) {
         if (data.id !== id || instance?.id !== Utils.getNameFromURL(id))
           deactivateEditor();
       },
-      [id, activateEditor]
+      [id, deactivateEditor]
     );
 
     /**
@@ -93,6 +94,8 @@ export function withEditorPlugin(ReactComponent, methods = []) {
         );
 
         if (validTab && data.id === id) {
+          // We should reset bookmarks when changing tabs. Right? And Left too :D
+          PluginManagerIDE.resetBookmarks();
           updateRightMenu();
           activateEditor();
         }
@@ -110,7 +113,18 @@ export function withEditorPlugin(ReactComponent, methods = []) {
         off(PLUGINS.TABS.NAME, PLUGINS.TABS.ON.ACTIVE_TAB_CHANGE);
         off(PLUGINS.DOC_MANAGER.NAME, PLUGINS.DOC_MANAGER.ON.UPDATE_DOC_DIRTY);
       };
-    }, [id, addKeyBind, removeKeyBind, on, off, save, activateThisEditor]);
+    }, [
+      id,
+      addKeyBind,
+      removeKeyBind,
+      on,
+      off,
+      save,
+      call,
+      updateRightMenu,
+      activateThisEditor,
+      activateEditor
+    ]);
 
     return (
       <div