New release (#176)

* Update node instances when port messages change * update pipelines * No longer saving NodeInstance's Parameter Types (#131) * - [FP-2474 - Search node tool fails for big flows](https://movai.atlassian.net/browse/FP-2474) (#135) * Added a way for the BaseApp keybinds to work (#130) * - [FP-2447 - Info tab closes when adding an import](https://movai.atlassian.net/browse/FP-2447) (#144) * - [FP-2465 - Data-testids for IDE](https://movai.atlassian.net/browse/FP-2465) (#145) * FP-2447 - Info tab closes when adding an import (#147) * fix bug FP-2447 * remove console.log * add eslint and add dependcy array * - [FP-2481 - Can't start a valid flow in tree view - Start link(s) not found](https://movai.atlassian.net/browse/FP-2481) (#148) * FP-2466: Prevent multiple subscribes in Flow onReady function (#151) * Prevent multiple subscribes in Flow onReady function * update changelog * Weird react bug with useCallback fixed --------- Co-authored-by: PedroCristovao-Movai <[email protected]> * rmove _mockLogin * FP-2467: We are now correctly deleting exposed ports on node deletion (#155) * We are now correctly deleting exposed ports on node deletion * update changelog --------- Co-authored-by: PedroCristovao-Movai <[email protected]> * FP-2277: Give back focus to Flow Editor after losing focus on some cases (#161) * Give back focus to Flow Editor after losing focus on some cases * Added changelog entry * update changelog --------- Co-authored-by: PedroCristovao-Movai <[email protected]> * FP-2480: Added misc shortcuts to help with search node (#152) * Added misc shortcuts to help with search node * removed unused import * Don't deactivateEditorKeybinds after nodeSelection on search --------- Co-authored-by: Paulo Andre Azevedo Quirino <[email protected]> * - [FP-2473 - IDE Flows appear as running but nodes don't in tree view… (#163) * - [FP-2473 - IDE Flows appear as running but nodes don't in tree view](https://movai.atlassian.net/browse/FP-2473) WIP * - [FP-2519 - nodes on tree view show as alive when they are not](https://movai.atlassian.net/browse/FP-2519) (#164) * Fix additional bugs with node status (not shutting down nodes when parent gets turned off) Also some comments on the PR * Fix not being able to stop nodes * Remove SonarCloud 'bug' * FP-2535: Fixed issue with deleting subflows from flow (#168) * Fixed issue with deleting subflows from flow * Added changelog entry * Added ParameterWithType for instances that need to save the type * ammend changelog entry * Fp 2540 duplicated code on the new merge request (#171) * Refactor ParameterWithType * Adds CHANGELOG * FP-2541 - Invalid links warning message is missing in removing port (#173) * Revert "FP-2541 - Invalid links warning message is missing in removing port (#173)" (#175) This reverts commit 35f8688. * FP-2542: Removed code that prevented flow validations from running (#174) * Removed code that prevented flow validations from running * Removed unused code, setShowWarnings to true by default * removed unused comment --------- Co-authored-by: Manuel Nogueira <[email protected]> Co-authored-by: PedroCristovao-Movai <[email protected]> Co-authored-by: PedroCristovao-Movai <[email protected]> Co-authored-by: Manuel Nogueira <[email protected]> Co-authored-by: Paulo Andre Azevedo Quirino <[email protected]>
MOV-AI · Jul 28, 2023 · 6bdeca5 · 6bdeca5
1 parent 9dbbf01
commit 6bdeca5
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 33 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 # 1.0.0 --installs on--> 2.4 IDE-EE / 3.1 IDE-CE
 
-
+- [FP-2542 - Removed code that prevented flow validations from running](https://movai.atlassian.net/browse/FP-2542)
 - [FP-2540 - Duplicated code on the new merge request](https://movai.atlassian.net/browse/FP-2540)
 - [FP-2530 - Added ParameterWithType for instances that need to save the type](https://movai.atlassian.net/browse/FP-2530)
 - [FP-2359 - Added a way for the BaseApp keybinds to work](https://movai.atlassian.net/browse/FP-2359)

diff --git a/src/editors/Flow/view/Core/Graph/GraphBase.js b/src/editors/Flow/view/Core/Graph/GraphBase.js
@@ -607,8 +607,7 @@ export default class GraphBase {
     // is this a subflow node?
     const [first, ...rest] = nodeName.split("__");
 
-    if (first !== this.mInterface.id)
-      throw new Error("GraphBase.updateNodeStatus: update for other flow? " + first);
+    if (first !== this.mInterface.id) return;
 
     if (rest.length)
       for (let i = 0; i < rest.length; i++) {

diff --git a/src/editors/Flow/view/Flow.jsx b/src/editors/Flow/view/Flow.jsx
@@ -95,7 +95,7 @@ export const Flow = (props, ref) => {
   const [runningFlow, setRunningFlow] = useState("");
   const [warnings, setWarnings] = useState([]);
   const [flowDebugging, setFlowDebugging] = useState();
-  const [warningsVisibility, setWarningsVisibility] = useState(false);
+  const [warningsVisibility, setWarningsVisibility] = useState(true);
   const [viewMode, setViewMode] = useState(FLOW_VIEW_MODE.default);
   const [tooltipConfig, setTooltipConfig] = useState(null);
   const [contextMenuOptions, setContextMenuOptions] = useState(null);
@@ -158,11 +158,11 @@ export const Flow = (props, ref) => {
    */
   const startNode = useCallback(
     node => {
-      commandNode("RUN", node, robotSelected).then(() => {
+      commandNode("RUN", node).then(() => {
         node.statusLoading = true;
       });
     },
-    [robotSelected, commandNode]
+    [commandNode]
   );
 
   /**
@@ -171,11 +171,11 @@ export const Flow = (props, ref) => {
    */
   const stopNode = useCallback(
     node => {
-      commandNode("KILL", node, robotSelected).then(() => {
+      commandNode("KILL", node).then(() => {
         node.statusLoading = true;
       });
     },
-    [robotSelected, commandNode]
+    [commandNode]
   );
 
   /**
@@ -486,7 +486,7 @@ export const Flow = (props, ref) => {
         )
       };
     },
-    [MENUS, call, id, instance, openDoc, getMenuComponent, t]
+    [call, id, instance, openDoc, getMenuComponent, t]
   );
 
   /**
@@ -530,7 +530,7 @@ export const Flow = (props, ref) => {
         )
       };
     },
-    [MENUS, call, id, instance, t]
+    [call, id, instance, t]
   );
 
   /**
@@ -608,7 +608,6 @@ export const Flow = (props, ref) => {
       activeBookmark
     );
   }, [
-    MENUS,
     id,
     name,
     instance,
@@ -683,17 +682,6 @@ export const Flow = (props, ref) => {
    *                                                                                      */
   //========================================================================================
 
-  /**
-   * On flow validation
-   * @param {*} validationWarnings
-   */
-  const onFlowValidated = validationWarnings => {
-    const persistentWarns = validationWarnings.warnings.filter(
-      el => el.isPersistent
-    );
-    setWarnings(persistentWarns);
-  };
-
   /**
    * Remove Node Bookmark and set selectedNode to null
    */
@@ -705,7 +693,7 @@ export const Flow = (props, ref) => {
       MENUS.current.DETAIL.NAME
     );
     selectedNodeRef.current = null;
-  }, [MENUS, call, selectedNodeRef]);
+  }, [call, selectedNodeRef]);
 
   /**
    * On Node Selected
@@ -729,7 +717,7 @@ export const Flow = (props, ref) => {
         }
       }, 300);
     },
-    [MENUS, addNodeMenu, unselectNode, onLinkSelected]
+    [addNodeMenu, unselectNode, onLinkSelected]
   );
 
   /**
@@ -831,15 +819,13 @@ export const Flow = (props, ref) => {
       );
 
       // Subscribe to flow validations
-      interfaceSubscriptionsList.current.push(
-        mainInterface.graph.onFlowValidated.subscribe(evtData => {
-          const persistentWarns = evtData.warnings.filter(
-            el => el.isPersistent
-          );
+      mainInterface.graph.onFlowValidated.subscribe(evtData => {
+        const persistentWarns = evtData.warnings.filter(
+          el => el.isPersistent
+        );
 
-          onFlowValidated({ warnings: persistentWarns });
-        })
-      );
+        setWarnings(persistentWarns);
+      });
 
       mainInterface.onLoad = () => setLoading(false);
 

diff --git a/src/editors/Flow/view/Views/BaseFlow.jsx b/src/editors/Flow/view/Views/BaseFlow.jsx
@@ -103,7 +103,7 @@ const BaseFlow = props => {
           <Loader />
         </Backdrop>
       )}
-      <div className={classes.flowCanvas} id={containerId} tagindex="0">
+      <div className={classes.flowCanvas} id={containerId} tabIndex="0">
         {warnings.length > 0 && (
           <Warnings warnings={warnings} isVisible={warningsVisibility} />
         )}