Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add mistralai support #192

Merged
merged 6 commits into from
Sep 10, 2024
Merged

[MRG] Add mistralai support #192

merged 6 commits into from
Sep 10, 2024

Conversation

suryavanshi
Copy link
Contributor

  • Added support for MistralAI SDK
  • The Mistral model (test with - mistral-large-latest) doesn't always return json, so also added a function to use regex to get proper json.
  • Also found a bug here - - currently when providing a dataset its getting set to 'None'

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working enhancement New feature or request labels Sep 9, 2024
@HuaizhengZhang
Copy link
Contributor

wow. thanks for your contribution. expect to merge it.

ping us and add [MRG] if your pr is ready to be reviewed.

mle/agents/advisor.py Outdated Show resolved Hide resolved
@huangyz0918
Copy link
Contributor

Would you like to follow this up? @leeeizhang

@leeeizhang
Copy link
Collaborator

Would you like to follow this up? @leeeizhang

yes, i will improve some details and test it soon.

@suryavanshi
Copy link
Contributor Author

wow. thanks for your contribution. expect to merge it.

ping us and add [MRG] if your pr is ready to be reviewed.

Thanks, I think mistral json mode doesn't always work, so looking into it.

Copy link
Collaborator

@leeeizhang leeeizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@leeeizhang leeeizhang changed the title Add mistralai support [MRG] Add mistralai support Sep 10, 2024
@huangyz0918 huangyz0918 merged commit 6c9812c into MLSysOps:main Sep 10, 2024
3 checks passed
@huangyz0918
Copy link
Contributor

Thank you! 👍 @suryavanshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants