Remove hard dependency on psycopg2 #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing django.contrib.postgres.search requires having psycopg2 installed, which often requires compiling psycopg2 from source, which can be a nuisance. Remove this hard dependency (only import the module if the relevant backend is being used) so that it's possible to run a demo server using sqlite without having psycopg2 installed.
|
Feels odd to do this but...okay! Don't see any strong reason why not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing the
django.contrib.postgres.searchmodule requires importingpsycopg2. Installingpsycopg2can be a minor nuisance and is otherwise unnecessary if you're not using the postgres backend.