Forbid blank ethics_statement (#2301)

A project should not be submittable if its "Ethics Statement" is blank. It is not sufficient to check that ethics_statement is a non-empty string: a string such as `<p> </p>` will appear as blank, and should not be accepted. (Note that CKEditor will often output something like `<p> </p>` when the field appears to be empty.) There's no reason not to handle ethics_statement in exactly the same way as all the other required content fields (REQUIRED_FIELDS.) Fixes #2239
MIT-LCP · Sep 20, 2024 · 0bb6350 · 0bb6350
2 parents 8011c41 + 24fc01e
commit 0bb6350
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/physionet-django/project/modelcomponents/activeproject.py b/physionet-django/project/modelcomponents/activeproject.py
@@ -162,21 +162,25 @@ class ActiveProject(Metadata, UnpublishedProject, SubmissionInfo):
 
     REQUIRED_FIELDS = (
         # 0: Database
-        ('title', 'abstract', 'background', 'methods', 'content_description',
-         'usage_notes', 'conflicts_of_interest', 'version', 'license',
-         'short_description'),
+        ('title', 'abstract', 'background',
+         'methods', 'content_description', 'usage_notes',
+         'ethics_statement', 'conflicts_of_interest',
+         'version', 'license', 'short_description'),
         # 1: Software
-        ('title', 'abstract', 'background', 'content_description',
-         'usage_notes', 'installation', 'conflicts_of_interest', 'version',
-         'license', 'short_description'),
+        ('title', 'abstract', 'background',
+         'content_description', 'usage_notes', 'installation',
+         'ethics_statement', 'conflicts_of_interest',
+         'version', 'license', 'short_description'),
         # 2: Challenge
-        ('title', 'abstract', 'background', 'methods', 'content_description',
-         'usage_notes', 'conflicts_of_interest', 'version', 'license',
-         'short_description'),
+        ('title', 'abstract', 'background',
+         'methods', 'content_description', 'usage_notes',
+         'ethics_statement', 'conflicts_of_interest',
+         'version', 'license', 'short_description'),
         # 3: Model
-        ('title', 'abstract', 'background', 'methods', 'content_description',
-         'usage_notes', 'installation', 'conflicts_of_interest', 'version',
-         'license', 'short_description'),
+        ('title', 'abstract', 'background',
+         'methods', 'content_description', 'usage_notes', 'installation',
+         'ethics_statement', 'conflicts_of_interest',
+         'version', 'license', 'short_description'),
     )
 
     # Custom labels that don't match model field names
@@ -345,10 +349,6 @@ def check_integrity(self):
                 l = self.LABELS[self.resource_type.id][attr] if attr in self.LABELS[self.resource_type.id] else attr.title().replace('_', ' ')
                 self.integrity_errors.append('Missing required field: {0}'.format(l))
 
-        # Ethics
-        if not self.ethics_statement:
-            self.integrity_errors.append('Missing required field: Ethics Statement')
-
         published_projects = self.core_project.publishedprojects.all()
         if published_projects:
             published_versions = [p.version for p in published_projects]