date_range: update freq string #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well no - we already test with pinned (even older) versions of xarray and pandas. So can merge on green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
===========================================
- Coverage 87.90% 50.32% -37.59%
===========================================
Files 40 50 +10
Lines 1745 3527 +1782
===========================================
+ Hits 1534 1775 +241
- Misses 211 1752 +1541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Oh thank you, almost started this myself. Warnings look good! |
veni-vidi-vici-dormivi
approved these changes
Aug 21, 2024
|
Thanks |
veni-vidi-vici-dormivi
pushed a commit
to veni-vidi-vici-dormivi/mesmer
that referenced
this pull request
Aug 21, 2024
* date_range: update freq string * add freq conditionals
mathause
added a commit
that referenced
this pull request
Aug 22, 2024
* add mesmer_m example script * changelog * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused imports * adjustments * replace script with notebook * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * restructure and add some headings * remove inputs * add some comments * typos * date_range: update freq string (#504) * date_range: update freq string * add freq conditionals * reference: only year as link (#505) * nits * more info on time coordinate * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update comment & clear output --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <[email protected]> Co-authored-by: Mathias Hauser <[email protected]>
veni-vidi-vici-dormivi
pushed a commit
to veni-vidi-vici-dormivi/mesmer
that referenced
this pull request
Aug 24, 2024
* date_range: update freq string * add freq conditionals
veni-vidi-vici-dormivi
added a commit
to veni-vidi-vici-dormivi/mesmer
that referenced
this pull request
Aug 24, 2024
* add mesmer_m example script * changelog * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused imports * adjustments * replace script with notebook * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * restructure and add some headings * remove inputs * add some comments * typos * date_range: update freq string (MESMER-group#504) * date_range: update freq string * add freq conditionals * reference: only year as link (MESMER-group#505) * nits * more info on time coordinate * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update comment & clear output --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <[email protected]> Co-authored-by: Mathias Hauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid some warnings in the tests. I am pretty sure
"YE"is also fine for older versions of pandas/ xarray but should probably run with #503 merged, so marking as draft for now.