Revert numpy build pinning changes #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4261 +/- ##
===========================================
+ Coverage 93.40% 93.41% +0.01%
===========================================
Files 169 183 +14
Lines 22204 23309 +1105
Branches 4064 4064
===========================================
+ Hits 20740 21775 +1035
- Misses 948 1018 +70
Partials 516 516 ☔ View full report in Codecov by Sentry. |
IAlibay
commented
Aug 28, 2023
| @@ -23,6 +23,8 @@ Fixes | |||
| Enhancements | |||
|
|
|||
| Changes | |||
| * Reverts PR #4108, builds are now again made using the oldest | |||
There was a problem hiding this comment.
I would just cut a bugfix release out of the current state of 2.7.0, rather than cherry pick - everything here seems like sensible bug fixes imho.
|
Seems like this is the preferred path (at least for now). I'm going to call a merge freeze on non-bugfix things. @MDAnalysis/coredevs can I have a priority review here please? |
richardjgowers
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4260
This reverts the numpy build pinning and would allow us to move forward with a 2.6.1 release.
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4261.org.readthedocs.build/en/4261/