-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pore analyser to md kits #172
base: main
Are you sure you want to change the base?
Conversation
There seem to be problems with python3.13: I have added python requirements <=3.12. |
Restarting CI by closing and reopening... (or you could make a minimal change to the PR...) |
@fiona-naughton could you please handle this kit? Feel free to ask me any hole-related questions (or maybe @lilyminium , too?) |
## The default below _might_ be sufficient or you might not even need MDAnalysisTests: | ||
## make sure that it is appropriate for how you run tests. | ||
test_dependencies: | ||
- mamba install pytest MDAnalysisTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need pytest if you're using unittest above?
|
||
## str: the development status of the MDAKit | ||
## See https://pypi.org/classifiers/ for development status classifiers. | ||
#development_status: Production/Stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add it — there's no shame in labelling it as alpha or beta. Or stable or mature ;-)
#development_status: Production/Stable | ||
|
||
publications: | ||
- https://doi.org/10.1016/j.bpj.2024.07.010 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on the paper! 🎉
Not sure why Python 3.13 is installed. @IAlibay said on Discord he'll look into it. |
Hi MDA community,
I would like to add PoreAnalyser. https://www.sciencedirect.com/science/article/pii/S0006349524004491?via%3Dihub
I have written the tests not with pytest and might need some help with the test section in the metadata file.