Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pore analyser to md kits #172

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DSeiferth
Copy link

Hi MDA community,

I would like to add PoreAnalyser. https://www.sciencedirect.com/science/article/pii/S0006349524004491?via%3Dihub
I have written the tests not with pytest and might need some help with the test section in the metadata file.

@DSeiferth
Copy link
Author

There seem to be problems with python3.13:
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

I have added python requirements <=3.12.
In my CI, I can succsefully install PoreAnalyser with python version 3.9 - 3.12
How can I restart the failed tests?
I have published a new pip installable version of PoreAnalyser where I have specified the python requirements.

@orbeckst
Copy link
Member

orbeckst commented Oct 8, 2024

Restarting CI by closing and reopening... (or you could make a minimal change to the PR...)

@orbeckst
Copy link
Member

orbeckst commented Oct 8, 2024

@fiona-naughton could you please handle this kit?

Feel free to ask me any hole-related questions (or maybe @lilyminium , too?)

@orbeckst orbeckst added mdakit About an MDAKit. new create a new MDAKit labels Oct 8, 2024
## The default below _might_ be sufficient or you might not even need MDAnalysisTests:
## make sure that it is appropriate for how you run tests.
test_dependencies:
- mamba install pytest MDAnalysisTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need pytest if you're using unittest above?


## str: the development status of the MDAKit
## See https://pypi.org/classifiers/ for development status classifiers.
#development_status: Production/Stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add it — there's no shame in labelling it as alpha or beta. Or stable or mature ;-)

#development_status: Production/Stable

publications:
- https://doi.org/10.1016/j.bpj.2024.07.010
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on the paper! 🎉

@orbeckst
Copy link
Member

orbeckst commented Oct 8, 2024

Not sure why Python 3.13 is installed. @IAlibay said on Discord he'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mdakit About an MDAKit. new create a new MDAKit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants