Feat/tck projection #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthieuMAIF
force-pushed
the
feat/tck_projection
branch
2 times, most recently
from
44f89aa
to
da91a59
Compare
ptitFicus
requested changes
Jul 26, 2021
| .filter(e -> { | ||
| return Option.of(query.entityId).map(id -> id.equals(e.entityId)).getOrElse(true); | ||
| }); | ||
| .filter(e -> Option.of(query.entityId).map(id -> id.equals(e.entityId)).getOrElse(true)); |
There was a problem hiding this comment.
I think this modification is unecessary for this feature. Could you remove it to clarify ?
| @@ -0,0 +1,26 @@ | |||
|
|
|||
There was a problem hiding this comment.
This schema is not used by TCK, therefore this file should be useless
|
|
||
|
|
||
| @Override | ||
| public void required_eventShouldBeConsumedByConsistentProjectionWhenEverythingIsAlright() { |
There was a problem hiding this comment.
Why is @test annotation missing on this method and the one below ?
| "org.testng" % "testng" % "6.3", | ||
| "com.typesafe.akka" %% "akka-stream" % akkaVersion % Test, | ||
| "org.mockito" % "mockito-core" % "3.6.28" % Test, | ||
| "fr.maif" %% "jooq-async-api" % jooqAsyncVersion |
Tests were not working since connection timeout was not setup on Postgres connection. Default timeout is infinite therefore test that shutdown BDD hangs.
MatthieuMAIF
force-pushed
the
feat/tck_projection
branch
from
3b478dc
to
635c19c
Compare
|
Fix #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.