implement calculation of balance functions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A wrong index was used, which resulted in nans. Also made sure the code works for $p = 0$.
They have been calculated incorrectly. The charge-only balance function still does not look right.
Instead output the numerator and denominator separately. This has the advantage that the results of several separate runs can be easily combined, because the division can be delayed until the last step, right before plotting the balance function.
This ensures deterministic results while giving different results for parallel runs.
The wrong signs were used, so B(pi+, pi-) was negative instead of positive. This is fixed here. Note that B(p, pbar) still seems to have the wrong sign for some reason.
This is a slight refactoring of Scott's and Garry's code. Use switch statements where appropriate (in one case this should improve performance) and return structs instead of modifying parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you tell me whether this looks good? (The code compiles, it is untested however.)