-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #249: Switch phpstan to include phpstan.neon.dist #627
Merged
mrdavidburns
merged 5 commits into
main
from
249--switch-phpstan-to-include-phpstan-neon-dist
Aug 5, 2024
Merged
Issue #249: Switch phpstan to include phpstan.neon.dist #627
mrdavidburns
merged 5 commits into
main
from
249--switch-phpstan-to-include-phpstan-neon-dist
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonel-lullabot
changed the title
Issue #249: Switch phpstan to include phpstan.neon.dist
[WIP] Issue #249: Switch phpstan to include phpstan.neon.dist
Jul 30, 2024
…o-include-phpstan-neon-dist
leonel-lullabot
changed the title
[WIP] Issue #249: Switch phpstan to include phpstan.neon.dist
Issue #249: Switch phpstan to include phpstan.neon.dist
Aug 1, 2024
leonel-lullabot
requested review from
justafish,
davereid,
deviantintegral and
mrdavidburns
August 1, 2024 16:26
mrdavidburns
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me and all checks are passing.
I would still appreciate getting a second approval on this before we merge.
mrdavidburns
deleted the
249--switch-phpstan-to-include-phpstan-neon-dist
branch
August 5, 2024 13:05
mrdavidburns
added a commit
that referenced
this pull request
Aug 8, 2024
This reverts commit cd5d5f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
-c
from the phpstan testphpstan.neon.dist
TestStatic.yml