Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #249: Switch phpstan to include phpstan.neon.dist #627

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Issue #249: Switch phpstan to include phpstan.neon.dist #627

merged 5 commits into from
Aug 5, 2024

Conversation

leonel-lullabot
Copy link
Collaborator

@leonel-lullabot leonel-lullabot commented Jul 30, 2024 •
edited
Loading

Fixes #249

  • Remove -c from the phpstan test
  • Scaffold phpstan.neon.dist
  • Update TestStatic.yml

@leonel-lullabot leonel-lullabot changed the title Issue #249: Switch phpstan to include phpstan.neon.dist [WIP] Issue #249: Switch phpstan to include phpstan.neon.dist Jul 30, 2024
@github-actions github-actions bot temporarily deployed to pantheon-pr-627 July 30, 2024 23:02 Destroyed
@github-actions github-actions bot temporarily deployed to pantheon-pr-627 July 31, 2024 22:27 Destroyed
@github-actions github-actions bot temporarily deployed to pantheon-pr-627 August 1, 2024 16:11 Destroyed
@github-actions github-actions bot temporarily deployed to pantheon-pr-627 August 1, 2024 16:17 Destroyed
@leonel-lullabot leonel-lullabot changed the title [WIP] Issue #249: Switch phpstan to include phpstan.neon.dist Issue #249: Switch phpstan to include phpstan.neon.dist Aug 1, 2024
@leonel-lullabot leonel-lullabot marked this pull request as ready for review August 1, 2024 16:26
@leonel-lullabot leonel-lullabot mentioned this pull request Aug 1, 2024
Closed
@mrdavidburns mrdavidburns mentioned this pull request Aug 1, 2024
Open
mrdavidburns
mrdavidburns approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@mrdavidburns mrdavidburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me and all checks are passing.
I would still appreciate getting a second approval on this before we merge.

@mrdavidburns mrdavidburns merged commit cd5d5f6 into main Aug 5, 2024
36 checks passed
@mrdavidburns mrdavidburns deleted the 249--switch-phpstan-to-include-phpstan-neon-dist branch August 5, 2024 13:05
mrdavidburns added a commit that referenced this pull request Aug 8, 2024
@mrdavidburns
Revert "Issue #249: Switch phpstan to include phpstan.neon.dist (#627)"
ef469c6 
This reverts commit cd5d5f6.
@mrdavidburns mrdavidburns mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdavidburns mrdavidburns mrdavidburns approved these changes

@justafish justafish Awaiting requested review from justafish

@davereid davereid Awaiting requested review from davereid

@deviantintegral deviantintegral Awaiting requested review from deviantintegral

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch phpstan to include phpstan.neon.dist
2 participants
@leonel-lullabot @mrdavidburns