Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Renovate/php 8.x luisaveiga #595

Closed
wants to merge 8 commits into from
Closed

WIP Renovate/php 8.x luisaveiga #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c8eb4ec
fix(deps): update dependency php to ^8.3.8
renovate[bot] Jun 7, 2024
3b54a2c
Use a different DDEV version
beto-aveiga Jun 19, 2024
6a24dab
Set DDEV version to 1.23.2 by default
beto-aveiga Jun 19, 2024
df00079
Restricting php versions to 8.3
beto-aveiga Jun 19, 2024
8eb1837
Set php 8.3 for Pantheon env
beto-aveiga Jun 19, 2024
fb5d270
Set the Pantheon environment later
beto-aveiga Jun 19, 2024
46503cf
not needed
beto-aveiga Jun 19, 2024
b39c4ec
use php 8.3 in pantheon
beto-aveiga Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/TestGitHubActions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
run: |
echo "api_version: 1" >> pantheon.yml
echo "web_docroot: true" >> pantheon.yml
echo "php_version: 8.1" >> pantheon.yml
echo "php_version: 8.3" >> pantheon.yml
echo "drush_version: 10" >> pantheon.yml
echo "database:" >> pantheon.yml
echo " version: 10.4" >> pantheon.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/composer-plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
php-version: [8.1, 8.2, 8.3]
php-version: [8.3]
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-production-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
php-version: [8.1, 8.2, 8.3]
php-version: [8.3]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"psr-4": {"Lullabot\\Drainpipe\\Tests\\Functional\\": "tests/src/functional/"}
},
"require": {
"php": "^8.1",
"php": "^8.3.8",
"ext-json": "*",
"composer-plugin-api": "^2.0",
"drush/drush": "^11|^12|^13",
Expand Down
2 changes: 1 addition & 1 deletion drainpipe-dev/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"psr-4": {"Lullabot\\DrainpipeDev\\Tests\\Functional\\": "tests/src/functional/"}
},
"require": {
"php": "^8.1",
"php": "^8.3.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to want to support PHP 8.1, 8.2, and 8.3.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear about what to do next.
If I don't change the PHP version, it won't work.
Do you have a suggestion on how to do it? My approach may be wrong.

"ext-json": "*",
"composer-plugin-api": "^2.0",
"phpunit/phpunit": "^9.6.19",
Expand Down
1 change: 1 addition & 0 deletions scaffold/github/actions/common/ddev/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ inputs:
version:
description: "Override the DDEV version .e.g. '1.19.0'"
required: false
default: "1.23.2"
runs:
using: "composite"
steps:
Expand Down
1 change: 0 additions & 1 deletion scaffold/github/actions/pantheon/review/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ runs:
run: |
source .github/actions/drainpipe/set-env/bash_aliases
drainpipe_exec "terminus workflow:wait ${{ inputs.site-name }}.pr-$DRAINPIPE_PR_NUMBER"

drainpipe_exec "terminus aliases --only ${{ inputs.site-name }} --yes"
if [ "${{ inputs.run-installer }}" == "true" ]; then
drainpipe_exec "./vendor/bin/drush @${{ inputs.site-name }}.pr-$DRAINPIPE_PR_NUMBER --yes site:install --existing-config"
Expand Down
Loading