ISSUE-220: replace using npx to execute action-validator, use the binary instead

[beto-aveiga]

Description

• Issue: npx @action-validator/cli is really slow compared to calling the binary directly #220
• Dowloads the binary of action-validator instead of using npx. Based on npx @action-validator/cli is really slow compared to calling the binary directly #220 (comment)
  • It took about 2 seconds to download the binary on my computer.
  • I tested that action-validator was executable with a new container, like:
    • docker run -it tugboatqa/php:8.2.15-apache-bullseye /bin/bash

[justafish]

Thanks for the PR. This would download the binary each time the task is run, instead could you please change it to use the the same installation method as we use for task and the local security checker e.g.
https://github.com/Lullabot/drainpipe/blob/main/src/BinaryInstaller.php
https://github.com/Lullabot/drainpipe/blob/main/drainpipe-dev/src/DevBinaryInstallerPlugin.php

[beto-aveiga]

@justafish I noticed that action-validator is only available for

• linux amd64
• linux arm64
• darwin amd64
• darwin arm64

Is that something we need to worry about? Or do something different in the binary installer? Or fallback to npx when the binary is not found?

[beto-aveiga]

I just added a fallback in case the binary is not available.

[deviantintegral]

I just added a fallback in case the binary is not available.

That would be if you were running on Windows, directly on the host? Do we actually support doing that? @justafish thoughts?

If we keep it, I think we should document that it's specifically for Windows support as a comment.

[justafish]

I added a minor tweak to the explicit path of the binary, and added Andrew's suggestion for a comment. I've tested this locally with the drainpipe-test script and all looks to be working well 👍

Thanks all!