Pull gitlab / github installer code into new methods #533
Conversation
|
[nesting intensifies] |
There was a problem hiding this comment.
@deviantintegral I fixed the database version error mismatch, which I thought was a result of a DDEV upgrade. I think the test failures are now genuine however as the Tugboat files don't seem to be be installed correctly.
scaffold/pantheon/pantheon.yml
Outdated
| @@ -2,6 +2,6 @@ api_version: 1 | |||
| web_docroot: true | |||
| php_version: 8.0 | |||
| database: | |||
| version: 10.4 | |||
| version: 10.11 | |||
There was a problem hiding this comment.
How do we feel about this change going out to all sites? Does this upgrade to several versions work okay on Pantheon deployments?
There was a problem hiding this comment.
I don't see 10.11 listed on https://docs.pantheon.io/pantheon-yml#specify-a-version-of-mariadb so does this need to be 10.6?
There was a problem hiding this comment.
yeah good point, let's change this to 10.6 - currently we only have Pantheon integration for GitLab, but we'd like to have it for GitHub 👍
deviantintegral
dismissed
justafish’s stale review
Database changes were fixed in other PRs
This PR pulls is the first two commits from https://github.com/Lullabot/drainpipe/pull/114/commits that: