Skip to content

Commit

Permalink
Issue #265: Upgrade Selenium images (#663)
Browse files Browse the repository at this point in the history
* Issue #265: Upgrade Selenium images

* Fix MINK_DRIVER_ARGS

* Switch to lullabot/mink-selenium2-driver
  • Loading branch information
justafish authored Aug 20, 2024
1 parent 02bc6a1 commit 4ca055c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/TestPHPUnit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
ddev composer config repositories.drainpipe-dev --json '{"type": "path", "url": "drainpipe-dev", "options": {"symlink": false}}'
ddev composer config minimum-stability dev
ddev composer require "lullabot/drainpipe @dev" --with-all-dependencies
ddev composer require "lullabot/drainpipe-dev @dev" weitzman/drupal-test-traits behat/mink-selenium2-driver --dev --with-all-dependencies
ddev composer require "lullabot/drainpipe-dev @dev" weitzman/drupal-test-traits lullabot/mink-selenium2-driver --dev --with-all-dependencies
# Restart is required to enable the provided Selenium containers
ddev restart
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: '3.6'
services:
chrome:
container_name: ddev-${DDEV_SITENAME}-chrome
image: seleniarm/standalone-chromium:4.1.2-20220227
image: selenium/standalone-chromium:127.0-20240820
labels:
com.ddev.site-name: ${DDEV_SITENAME}
com.ddev.approot: $DDEV_APPROOT
Expand All @@ -29,7 +29,7 @@ services:

firefox:
container_name: ddev-${DDEV_SITENAME}-firefox
image: seleniarm/standalone-firefox:4.1.2-20220227
image: selenium/standalone-firefox:129.0-20240820
labels:
com.ddev.site-name: ${DDEV_SITENAME}
com.ddev.approot: $DDEV_APPROOT
Expand Down
4 changes: 2 additions & 2 deletions scaffold/phpunit-testtraits.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
-->
<env name="BROWSERTEST_OUTPUT_BASE_URL" value=""/>
<!-- Example for changing the driver args to webdriver tests MINK_DRIVER_ARGS_WEBDRIVER value: '["chrome", { "chromeOptions": { "w3c": false } }, "http://localhost:4444/wd/hub"]' For using the Firefox browser, replace "chrome" with "firefox" -->
<env name="MINK_DRIVER_ARGS_WEBDRIVER" value='["chrome", {"browserName":"chrome","goog:chromeOptions":{"w3c": true, "args":["---no-sandbox","--ignore-certificate-errors", "--allow-insecure-localhost"]}}, "http://chrome:4444/wd/hub"]'/>
<env name="MINK_DRIVER_ARGS_WEBDRIVER" value='["chrome", {"browserName":"chrome","goog:chromeOptions":{"w3c": true, "args":["--no-sandbox","--ignore-certificate-errors", "--allow-insecure-localhost", "--disable-dev-shm-usage", "--dns-prefetch-disable"]}}, "http://chrome:4444"]'/>
<!-- DTT settings https://gitlab.com/weitzman/drupal-test-traits -->
<env name="DTT_BASE_URL" value="http://web"/>
<env name="DTT_MINK_DRIVER_ARGS" value='["chrome", {"browserName":"chrome","goog:chromeOptions":{"w3c": true, "args":["---no-sandbox","--ignore-certificate-errors", "--allow-insecure-localhost"]}}, "http://chrome:4444/wd/hub"]'/>
<env name="DTT_MINK_DRIVER_ARGS" value='["chrome", {"browserName":"chrome","goog:chromeOptions":{"w3c": true, "args":["--no-sandbox","--ignore-certificate-errors", "--allow-insecure-localhost", "--disable-dev-shm-usage", "--dns-prefetch-disable"]}}, "http://chrome:4444"]'/>
</php>
<extensions>
<!-- Functional tests HTML output logging. -->
Expand Down
2 changes: 1 addition & 1 deletion scaffold/phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
-->
<env name="BROWSERTEST_OUTPUT_BASE_URL" value=""/>
<!-- Example for changing the driver args to webdriver tests MINK_DRIVER_ARGS_WEBDRIVER value: '["chrome", { "chromeOptions": { "w3c": false } }, "http://localhost:4444/wd/hub"]' For using the Firefox browser, replace "chrome" with "firefox" -->
<env name="MINK_DRIVER_ARGS_WEBDRIVER" value='["chrome", {"browserName":"chrome","goog:chromeOptions":{"w3c": true, "args":["---no-sandbox","--ignore-certificate-errors", "--allow-insecure-localhost"]}}, "http://chrome:4444/wd/hub"]'/>
<env name="MINK_DRIVER_ARGS_WEBDRIVER" value='["chrome", {"browserName":"chrome","goog:chromeOptions":{"w3c": true, "args":["---no-sandbox","--ignore-certificate-errors", "--allow-insecure-localhost", "--disable-dev-shm-usage", "--dns-prefetch-disable"]}}, "http://chrome:4444"]'/>
</php>
<extensions>
<!-- Functional tests HTML output logging. -->
Expand Down

0 comments on commit 4ca055c

Please sign in to comment.