Feature/letter receive #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show list of lettes that user received.
Open
yjb94
requested changes
Feb 10, 2021
.eslintrc.js
Outdated
Comment on lines
32
to
40
| 'prettier/prettier': [ | ||
| 'error', | ||
| { | ||
| endOfLine: 'auto', | ||
| }, | ||
| ], | ||
| }, | ||
| }; No newline at end of file | ||
| }; |
There was a problem hiding this comment.
뭔지 잘 모르겠음. prettierrc에서 되면 수정 부탁감사
Comment on lines
+12
to
+16
| const Wrapper = styled.div``; | ||
|
|
||
| const Writer = styled.div``; | ||
|
|
||
| const Content = styled.div``; |
Comment on lines
+13
to
+17
| const Wrapper = styled.div``; | ||
|
|
||
| const Writer = styled.div``; | ||
|
|
||
| const Thumbnail = styled.div``; |
Comment on lines
+23
to
+25
| <Text> | ||
| <Writer>{writer}</Writer> | ||
| </Text> |
There was a problem hiding this comment.
Suggested change
| <Text> | |
| <Writer>{writer}</Writer> | |
| </Text> | |
| <Writer>{writer}</Writer> |
Writer를 styled 컴포넌트로 Text 감싸게 하면 될 둣
Comment on lines
+6
to
+10
| export interface LetterProps extends Omit<LetterDataType, 'id'> { | ||
| content: string; | ||
| thumbnail: string; | ||
| writer: string; | ||
| } |
There was a problem hiding this comment.
Suggested change
| export interface LetterProps extends Omit<LetterDataType, 'id'> { | |
| content: string; | |
| thumbnail: string; | |
| writer: string; | |
| } | |
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | |
| export interface LetterProps extends Omit<LetterDataType, 'id' | 'thumbnail'> {} | |
Comment on lines
+7
to
+11
| export interface LetterProps extends Omit<LetterDataType, 'content'> { | ||
| id: string; | ||
| thumbnail: string; | ||
| writer: string; | ||
| } |
There was a problem hiding this comment.
Suggested change
| export interface LetterProps extends Omit<LetterDataType, 'content'> { | |
| id: string; | |
| thumbnail: string; | |
| writer: string; | |
| } | |
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | |
| export interface LetterProps extends Omit<LetterDataType, 'content'> {} |
Comment on lines
+10
to
+15
| export const emptyLetter: LetterDataType = { | ||
| id: '', | ||
| content: '', | ||
| writer: '', | ||
| thumbnail: '', | ||
| }; |
Comment on lines
+10
to
+15
|
|
||
| const LetterReadPage: React.FC = () => { | ||
| const history = useHistory(); | ||
| const letterId = history.location.pathname.substring(13); | ||
| const letterToRead: LetterDataType = | ||
| letters.find((letter) => letter.id === letterId) || emptyLetter; |
Comment on lines
+7
to
+9
| const Wrapper = styled.div``; | ||
|
|
||
| const ExitButton = styled.button``; |
| import styled from 'styled-components'; | ||
| import LetterThumbnail from '../components/Letter/LetterThumbnail'; | ||
| import { letters } from '../constants/Letters'; | ||
| const Wrapper = styled.div``; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.