Add run-tests to push workflow #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanaka
force-pushed
the
gha-run-tests
branch
7 times, most recently
from
a1780c0
to
a2ac877
Compare
The push workflow does checkout, installs npm modules (resolve-deps), does a build of conlink (using test1 compose), and then invokes run-tests.sh
|
@jonsmock when you get a chance, can you also push a docker and npm release of conlink 2.0.3? |
|
Also, npm and docker hub now have 2.0.3 artifacts. Thanks for catching that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables docker-compose based testing of examples/tests 1, 2, 4, and 7 (the ones that only require docker and docker-compose). Not sure we really want to have a shell based test driver long term, but for now this seems to do a decent job of testing and reporting pass/fail.