New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define ACCESSPERMS When Compiling With musl #389

Merged

NikolajSchlej merged 1 commit into LongSoft:new_engine from mischif:patch-1

Feb 20, 2024

Contributor

mischif commented Feb 20, 2024

Compiling UEFITool fails on Linux distros using the musl libc, such as Alpine, due to ACCESSPERMS not being defined in sys/stat.h:

uefitool/common/filesystem.cpp: In function 'bool makeDirectory(const Bstrlib::CBString&)':
uefitool/common/filesystem.cpp:86:38: error: 'ACCESSPERMS' was not declared in this scope
   86 |     return (mkdir(dir.toLocal8Bit(), ACCESSPERMS) == 0);
      |                                      ^~~~~~~~~~~

This PR creates a definition for ACCESSPERMS, allowing compilation to complete.


          Defined ACCESSPERMS for musl

bf16a12

Collaborator

NikolajSchlej commented Feb 20, 2024

Thanks, need to add such a linux into CI/CD matrix, so we can catch stuff like this next time

NikolajSchlej merged commit c550853 into LongSoft:new_engine

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet