launchd: only support setting command to a list
#1088
Conversation
|
Deprecating that seems reasonable, but I’m a bit worried that it means the obvious translation of |
|
I was thinking of changing the types to any options that set extra arguments to lists as well so that we can run them through |
Enzime
force-pushed
the
command-list
branch
2 times, most recently
from
2420824
to
e2af976
Compare
Enzime
changed the title
command to a listcommand to a list
Enzime
force-pushed
the
command-list
branch
4 times, most recently
from
7398e9b
to
ba765fa
Compare
Enzime
force-pushed
the
command-list
branch
from
ba765fa
to
c887748
Compare
| @@ -80,11 +72,11 @@ let | |||
| }; | |||
|
|
|||
| config = { | |||
| command = mkIf (config.script != "") (pkgs.writeScript "${name}-start" '' | |||
| command = mkIf (config.script != "") [ (pkgs.writeScript "${name}-start" '' | |||
There was a problem hiding this comment.
Should we add a wait4path in here? (I’m fine if you’d rather leave that to future work.)
There was a problem hiding this comment.
I don't think it's necessary as serviceConfig.ProgramArguments already does wait4path /nix/store
| @@ -91,7 +92,7 @@ in | |||
| # How often AutoSSH checks the network, in seconds | |||
| environment.AUTOSSH_POLL="30"; | |||
|
|
|||
| command = "${pkgs.autossh}/bin/autossh -M ${toString mport} ${s.extraArguments}"; | |||
| command = [ (lib.getExe pkgs.autossh) "-M" "${toString mport}" ] ++ s.extraArguments; | |||
There was a problem hiding this comment.
Looks like this is the only place where we pass arbitrary user arguments in this field. After this change users will have to adjust their configurations and wouldn’t be able to reference environment variables here any more. I’m okay with it if you are, but I’m guessing we might have services for which this is undesirable in future.
There was a problem hiding this comment.
In those situations, I think we should direct them to set serviceConfig.ProgramArguments directly (possibly with lib.mkAfter)
I did a quick GitHub Code search and didn't see any configs that used environment variables for services.autossh.extraArguments:
https://github.com/search?utf8=✓&q=path%3A*.nix+services+autossh+extraArguments&type=Code
@emilazy should I just deprecate setting
commandto a string with a warning?